-
Notifications
You must be signed in to change notification settings - Fork 421
feat: Exemplars for metric & PromQL charts #2536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jordan-simonovski
wants to merge
9
commits into
main
Choose a base branch
from
feat/exemplars
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
536e37b
feat(HDX) Added support for exemplars
jordan-simonovski c38448a
feat: Created a telemetry generator for local dev
jordan-simonovski 62bcb9c
feat: configured spanmetric generation for local testing
jordan-simonovski 935073d
Configured spanmetric generation and changesets
jordan-simonovski bebb8e2
Merge branch 'main' into feat/exemplars
jordan-simonovski d2bcfc4
Resolved knip and greptile stuff
jordan-simonovski 30fca77
fix: The endpoint is now resolved API-side and inlined into the gener…
jordan-simonovski d50b65f
Merge branch 'main' into feat/exemplars
jordan-simonovski d008634
Merge branch 'main' into feat/exemplars
jordan-simonovski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| "@hyperdx/common-utils": minor | ||
| "@hyperdx/api": minor | ||
| "@hyperdx/app": minor | ||
| --- | ||
|
|
||
| feat: add exemplar overlay for metric and PromQL charts | ||
|
|
||
| Time charts on metric and PromQL sources can now overlay exemplars — | ||
| individual data points linked to a trace — via the "Exemplars" toggle in the | ||
| chart editor (next to "As Ratio" for metric charts, in the PromQL editor for | ||
| PromQL charts). Markers snap onto the series line so the chart stays honest; | ||
| hovering a marker shows trace metadata (service, span, duration, status) from a | ||
| configurable exemplar trace source, with a button to open the trace directly. | ||
|
|
||
| For structured metric sources, exemplars are read directly from the OTel metric | ||
| tables' `Exemplars.*` columns (`renderMetricExemplarsChartConfig`), honoring the | ||
| chart's time range, metric name, and filters. For PromQL sources backed by a | ||
| real Prometheus endpoint, the new `/v1/prometheus/query_exemplars` route proxies | ||
| to Prometheus's native `/api/v1/query_exemplars`. The overlay is opt-in and runs | ||
| its query in parallel only when enabled, so charts that don't use it are | ||
| unaffected. Trace-source exemplar generation lands in a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| "@hyperdx/api": minor | ||
| "@hyperdx/otel-collector": minor | ||
| --- | ||
|
|
||
| feat: optional spanmetrics connector for metric exemplars | ||
|
|
||
| Adds the `spanmetricsconnector` to the collector build and wires it into the | ||
| OpAMP-generated collector config, gated on the `ENABLE_SPAN_METRICS` env flag | ||
| (off by default). When enabled, the collector derives `traces.span.metrics.*` | ||
| (calls + duration histogram) from spans with **exemplars enabled**, so the | ||
| duration histogram lands in ClickHouse with `Exemplars.*` pointing back at the | ||
| spans they were measured from — giving coherent, fully-OTLP metric exemplars | ||
| without any direct ClickHouse writes. Enabled in local dev to back the new | ||
| `telemetry-generator` service. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.