-
Notifications
You must be signed in to change notification settings - Fork 253
chore: modernize toolchain and harden audio workflows #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8689057
chore(deps): modernize the development toolchain
github-actions[bot] 5915087
fix(native): harden audio state transitions
github-actions[bot] 090ab91
test: add cross-platform audio regression coverage
github-actions[bot] 2486a4b
ci: harden build and release automation
github-actions[bot] ce6d0eb
docs: align compatibility and maintenance guidance
github-actions[bot] 38c2ee9
chore(workflows): add repository maintenance skills
github-actions[bot] f93ea13
fix(ci): retarget release tag after changelog amend
github-actions[bot] 414aabd
chore(skills): add canonical PR review workflow
github-actions[bot] eb77046
fix: address PR review findings
github-actions[bot] fc0787e
fix(ios): support Xcode 16 Bluetooth option
github-actions[bot] c8a34e1
fix(ios): avoid Xcode 16 Swift compiler crash
github-actions[bot] 104aacb
build(ios): require Xcode 26
github-actions[bot] 0a3097e
docs: align Xcode requirement
github-actions[bot] 1b0eb9e
test: stabilize simulator audio e2e
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| # Audit Code | ||
|
|
||
| Audit the selected react-native-nitro-sound surface against its public API, | ||
| Nitro contract, platform implementations, tests, examples, docs, and current | ||
| toolchain requirements. | ||
|
|
||
| ## Usage | ||
|
|
||
| ```text | ||
| /audit-code [path|api|ios|android|web|all] | ||
| ``` | ||
|
|
||
| An audit is read-only unless the user also asks for fixes. | ||
|
|
||
| ## Evidence Order | ||
|
|
||
| 1. Read `AGENTS.md` and `.codex/skills/nitro-sound-workflows/SKILL.md`. | ||
| 2. Resolve the requested paths and inspect their history when intent is unclear. | ||
| 3. Read `src/specs/*.nitro.ts`, `src/index.tsx`, Web implementation, hooks, | ||
| Swift, Kotlin, tests, example screens, README, FAQ, package metadata, and CI | ||
| that apply. | ||
| 4. For latest Nitro, React Native, Xcode, Android, or browser requirements, | ||
| verify official primary documentation rather than relying on memory. | ||
|
|
||
| ## Audit Lenses | ||
|
|
||
| - Public exports, types, defaults, units, errors, and backward compatibility | ||
| - Spec-to-generated-to-Swift/Kotlin wiring and codegen freshness | ||
| - Promise settlement, listener add/remove behavior, cleanup, idempotency, and | ||
| rapid start/stop concurrency | ||
| - Recorder/player state machines, seek, speed, volume, and playback completion | ||
| - iOS permission, AVAudioSession, interruption, route, and lifecycle behavior | ||
| - Android permission, MediaRecorder/MediaPlayer, audio focus, lifecycle, and ABI | ||
| build behavior | ||
| - Web MediaRecorder support, object URL cleanup, timers, and browser fallbacks | ||
| - Hooks cleanup and React lifecycle behavior | ||
| - Unit tests, example coverage, device evidence, docs, migration notes, and CI | ||
| - Generated-file policy, release safety, secret handling, and workflow permissions | ||
|
|
||
| ## Validate Findings | ||
|
|
||
| Every finding must identify the affected path, concrete failure mode, evidence, | ||
| severity, and smallest safe remediation. Confirm the finding against current | ||
| code and reject speculative or cosmetic observations. Distinguish: | ||
|
|
||
| - confirmed defect; | ||
| - coverage or verification gap; | ||
| - documentation drift; | ||
| - current external compatibility risk; | ||
| - blocked runtime claim requiring a device. | ||
|
|
||
| ## Output | ||
|
|
||
| List findings in severity order, then verification gaps and a concise clean-area | ||
| summary. If there are no actionable findings, say so and state which platforms | ||
| or runtime lanes were not exercised. Do not modify code unless the user asked | ||
| for implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.