Skip to content

fix: correct typo in find-achievement-files filename#2402

Open
obrenoalvim wants to merge 1 commit into
hydralauncher:mainfrom
obrenoalvim:fix/find-achievement-files-typo
Open

fix: correct typo in find-achievement-files filename#2402
obrenoalvim wants to merge 1 commit into
hydralauncher:mainfrom
obrenoalvim:fix/find-achievement-files-typo

Conversation

@obrenoalvim

Copy link
Copy Markdown

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read the Hydra documentation.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:

Fixes a typo in the filename find-achivement-files.ts (missing e in achievement). Renames the file to find-achievement-files.ts and updates the two import paths that referenced the old name.

Files changed:

  • src/main/services/achievements/find-achivement-files.ts → find-achievement-files.ts
  • src/main/services/achievements/achievement-watcher-manager.ts — updated import path
  • src/main/events/library/reset-game-achievements.ts — updated import path

Rename find-achivement-files.ts to find-achievement-files.ts and
update the two import references that used the misspelled path.
@greptile-apps

greptile-apps Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR corrects a long-standing typo in the filename find-achivement-files.ts (missing e in "achievement"), renaming it to find-achievement-files.ts and updating the two import sites that referenced the old name.

  • find-achivement-files.tsfind-achievement-files.ts: pure rename, no content changes.
  • achievement-watcher-manager.ts and reset-game-achievements.ts: single-line import path corrections to match the new filename.

Confidence Score: 5/5

Safe to merge — the change is a mechanical rename with no logic modifications.

The rename is complete: the old filename is gone, both import paths are updated, and a search confirms no remaining references to the misspelled name anywhere in the codebase. No functional code was altered.

No files require special attention.

Important Files Changed

Filename Overview
src/main/services/achievements/find-achievement-files.ts File renamed from find-achivement-files.ts to fix the missing 'e' in achievement; file contents unchanged.
src/main/services/achievements/achievement-watcher-manager.ts Import path updated from find-achivement-files to find-achievement-files; no logic changes.
src/main/events/library/reset-game-achievements.ts Import path updated from find-achivement-files to find-achievement-files; no logic changes.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant RGA as reset-game-achievements.ts
    participant AWM as achievement-watcher-manager.ts
    participant FAF as find-achievement-files.ts (renamed)

    RGA->>FAF: "import { findAchievementFiles }"
    AWM->>FAF: "import { findAchievementFiles, findAllAchievementFiles, getAlternativeObjectIds }"
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant RGA as reset-game-achievements.ts
    participant AWM as achievement-watcher-manager.ts
    participant FAF as find-achievement-files.ts (renamed)

    RGA->>FAF: "import { findAchievementFiles }"
    AWM->>FAF: "import { findAchievementFiles, findAllAchievementFiles, getAlternativeObjectIds }"
Loading

Reviews (1): Last reviewed commit: "fix: correct typo in find-achievement-fi..." | Re-trigger Greptile

@sonarqubecloud

Copy link
Copy Markdown

@Moyasee Moyasee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean rename, both import sites updated, no other references to the old path. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants