fix: localize classics details and profile platform dropdowns#2396
fix: localize classics details and profile platform dropdowns#2396Moyasee wants to merge 1 commit into
Conversation
|
Greptile SummaryThis PR adds missing
Confidence Score: 4/5Safe to merge — the changes are purely additive translation keys with no logic or structural risk. All three locale files receive accurate, correctly-spelled translations that match the English source keys. The only gap is that many other locales (de, zh, ar, and others) still lack the same keys and will keep falling back to English; this PR does not make things worse for them, but the fix remains incomplete across the full locale set. No individual file has a defect; the attention point is the locales not touched by this PR (de, zh, ar, and ~25 others) that are still missing the same keys. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[i18next key lookup] --> B{Key present in locale?}
B -- Yes --> C[Render translated string]
B -- No --> D[Fallback to 'en' locale]
D --> E[Render English string]
subgraph Before PR
F[es / pt-BR / pt-PT] -- missing keys --> D
end
subgraph After PR
G[es / pt-BR / pt-PT] -- added keys --> C
H[de / zh / ar / others] -- still missing --> D
end
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[i18next key lookup] --> B{Key present in locale?}
B -- Yes --> C[Render translated string]
B -- No --> D[Fallback to 'en' locale]
D --> E[Render English string]
subgraph Before PR
F[es / pt-BR / pt-PT] -- missing keys --> D
end
subgraph After PR
G[es / pt-BR / pt-PT] -- added keys --> C
H[de / zh / ar / others] -- still missing --> D
end
Reviews (1): Last reviewed commit: "fix: localize classics details and profi..." | Re-trigger Greptile |



When submitting this pull request, I confirm the following (please check the boxes):
Fill in the PR content:
The classics "Details" dropdown (
game_detailsnamespace) and the profile platform-selection dropdown (user_profilenamespace) were showing English text in locales that lacked the keys, since i18next falls back to English.The keys already existed in
en,ruandfr. This adds them to the locales we keep in parity:game_details:details,platform,genres,regions,region_us/eu/jp/kr/asiauser_profile:platform,platform_all,platform_pc(plusplatform_classicsfor pt-PT)Updated:
pt-BR,pt-PT,es.