Skip to content

fix: localize classics details and profile platform dropdowns#2396

Open
Moyasee wants to merge 1 commit into
mainfrom
fix/LBX-811
Open

fix: localize classics details and profile platform dropdowns#2396
Moyasee wants to merge 1 commit into
mainfrom
fix/LBX-811

Conversation

@Moyasee

@Moyasee Moyasee commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read the Hydra documentation.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:

The classics "Details" dropdown (game_details namespace) and the profile platform-selection dropdown (user_profile namespace) were showing English text in locales that lacked the keys, since i18next falls back to English.

The keys already existed in en, ru and fr. This adds them to the locales we keep in parity:

  • game_details: details, platform, genres, regions, region_us/eu/jp/kr/asia
  • user_profile: platform, platform_all, platform_pc (plus platform_classics for pt-PT)

Updated: pt-BR, pt-PT, es.

@sonarqubecloud

Copy link
Copy Markdown

@greptile-apps

greptile-apps Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds missing game_details and user_profile translation keys to the Spanish (es), Brazilian Portuguese (pt-BR), and European Portuguese (pt-PT) locales, preventing i18next from silently falling back to English strings for the classics details and profile platform dropdowns.

  • game_details: Adds details, platform, genres, regions, and five region_* keys to all three locales; translations use correct regional conventions (e.g. Géneros in pt-PT vs. Gêneros in pt-BR).
  • user_profile: Adds platform, platform_all, and platform_pc to all three locales, plus platform_classics to pt-PT where it was uniquely absent.
  • Many other locales (e.g. de, zh, ar) are still missing the same keys and will continue to fall back to English; a follow-up pass over the remaining locales would fully resolve the issue.

Confidence Score: 4/5

Safe to merge — the changes are purely additive translation keys with no logic or structural risk.

All three locale files receive accurate, correctly-spelled translations that match the English source keys. The only gap is that many other locales (de, zh, ar, and others) still lack the same keys and will keep falling back to English; this PR does not make things worse for them, but the fix remains incomplete across the full locale set.

No individual file has a defect; the attention point is the locales not touched by this PR (de, zh, ar, and ~25 others) that are still missing the same keys.

Important Files Changed

Filename Overview
src/locales/es/translation.json Adds 9 missing game_details keys (details, platform, genres, regions, region_*) and 3 missing user_profile keys (platform, platform_all, platform_pc) to the Spanish locale; translations are linguistically accurate and correctly placed.
src/locales/pt-BR/translation.json Adds the same 9 game_details keys and 3 user_profile keys to Brazilian Portuguese; uses correct regional spellings (e.g. "Gêneros" with circumflex accent).
src/locales/pt-PT/translation.json Adds 9 game_details keys and all 4 user_profile platform keys (including platform_classics which was also missing here); uses correct European Portuguese spelling (e.g. "Géneros" with acute accent vs. the Brazilian circumflex).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[i18next key lookup] --> B{Key present in locale?}
    B -- Yes --> C[Render translated string]
    B -- No --> D[Fallback to 'en' locale]
    D --> E[Render English string]

    subgraph Before PR
        F[es / pt-BR / pt-PT] -- missing keys --> D
    end

    subgraph After PR
        G[es / pt-BR / pt-PT] -- added keys --> C
        H[de / zh / ar / others] -- still missing --> D
    end
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[i18next key lookup] --> B{Key present in locale?}
    B -- Yes --> C[Render translated string]
    B -- No --> D[Fallback to 'en' locale]
    D --> E[Render English string]

    subgraph Before PR
        F[es / pt-BR / pt-PT] -- missing keys --> D
    end

    subgraph After PR
        G[es / pt-BR / pt-PT] -- added keys --> C
        H[de / zh / ar / others] -- still missing --> D
    end
Loading

Reviews (1): Last reviewed commit: "fix: localize classics details and profi..." | Re-trigger Greptile

Comment thread src/locales/es/translation.json
@Moyasee Moyasee added the bug Something isn't working label Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant