Fix: undrawn knockout fixtures block point scoring#51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A
wm2026(Football World Cup 2026) competition showed finished games but never calculated points. Root cause: the data payload includes knockout-bracket fixtures whose teams aren't drawn yet (emptyhome_external_id/away_external_id).applyGame()recorded each as an error, soSyncReport::isSuccess()returned false, and the scoring guardif ($report->isSuccess() && $report->updated > 0)skippedscoreAllFinishedGames()for the whole competition — on every cron run and every Sync Results click.Changes
HumHubApiAdapter::applyGame) — empty team IDs now count asskipped, keeping the sync report clean.actionSetupWm2026) — runsscoreAllFinishedGames+ matchday bonuses + special-bet auto-resolve, instead of leaving finished games unscored until the next cron.flashReport, competition create, schedule auto-load, tip + special-bet save) now write to thekickoffapp-log category, so issues are traceable when a flash toast isn't seen.Notes
module.jsonbumped to1.0.8; CHANGELOG section added (still(Unreleased)— date stamped at release).