Skip to content

Fix: undrawn knockout fixtures block point scoring#51

Merged
kilgor-trout-c22 merged 3 commits into
masterfrom
fix/auto-recalc-points
Jun 12, 2026
Merged

Fix: undrawn knockout fixtures block point scoring#51
kilgor-trout-c22 merged 3 commits into
masterfrom
fix/auto-recalc-points

Conversation

@kilgor-trout-c22

Copy link
Copy Markdown
Contributor

Problem

A wm2026 (Football World Cup 2026) competition showed finished games but never calculated points. Root cause: the data payload includes knockout-bracket fixtures whose teams aren't drawn yet (empty home_external_id/away_external_id). applyGame() recorded each as an error, so SyncReport::isSuccess() returned false, and the scoring guard if ($report->isSuccess() && $report->updated > 0) skipped scoreAllFinishedGames() for the whole competition — on every cron run and every Sync Results click.

Changes

  • Skip undrawn knockout fixtures instead of erroring (HumHubApiAdapter::applyGame) — empty team IDs now count as skipped, keeping the sync report clean.
  • Decouple scoring from sync success in all three sync paths (hourly/daily cron, live cron, Sync Results button) — scoring is idempotent, so a partial error no longer blocks scoring of cleanly-imported finished games.
  • FWC 2026 setup now scores immediately (actionSetupWm2026) — runs scoreAllFinishedGames + matchday bonuses + special-bet auto-resolve, instead of leaving finished games unscored until the next cron.
  • Log genuine failures — sync/save failures (flashReport, competition create, schedule auto-load, tip + special-bet save) now write to the kickoff app-log category, so issues are traceable when a flash toast isn't seen.

Notes

  • module.json bumped to 1.0.8; CHANGELOG section added (still (Unreleased) — date stamped at release).

@kilgor-trout-c22 kilgor-trout-c22 merged commit beca3d5 into master Jun 12, 2026
16 checks passed
@kilgor-trout-c22 kilgor-trout-c22 deleted the fix/auto-recalc-points branch June 12, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant