Skip to content

Issue - Fix sidebar widget issue#629

Merged
luke- merged 3 commits into
v1.7from
fix/sidebar-widget-issue
Oct 28, 2025
Merged

Issue - Fix sidebar widget issue#629
luke- merged 3 commits into
v1.7from
fix/sidebar-widget-issue

Conversation

@gevorgmansuryan

Copy link
Copy Markdown
Contributor

@gevorgmansuryan gevorgmansuryan requested a review from luke- October 25, 2025 23:41
@gevorgmansuryan gevorgmansuryan self-assigned this Oct 25, 2025
@luke-

luke- commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

@yurabakhtin Can you please rview?

@luke- luke- requested a review from yurabakhtin October 27, 2025 10:12
Comment thread interfaces/event/AbstractCalendarQuery.php Outdated
@yurabakhtin

Copy link
Copy Markdown
Collaborator

@gevorgmansuryan Many unit tests for master have errors, they all must be fixed, I didn't check why they are broken but probably new query changed the behaviour.

@gevorgmansuryan

Copy link
Copy Markdown
Contributor Author

@yurabakhtin tests are broken because of outdated test config, its fixed in v1.8 already. As this temp branch i think its ok

@yurabakhtin

Copy link
Copy Markdown
Collaborator

tests are broken because of outdated test config, its fixed in v1.8 already. As this temp branch i think its ok

@gevorgmansuryan It is ok that for v1.17 only master tests work without error, we should not fix develop and next tests here.

@yurabakhtin

Copy link
Copy Markdown
Collaborator

Can you please rview?

@luke- I have tested, I don't see any pas events after this fix, but before they were visible.

@luke- luke- merged commit ee6e694 into v1.7 Oct 28, 2025
8 of 14 checks passed
@luke- luke- deleted the fix/sidebar-widget-issue branch October 28, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants