Skip to content

Fix tests#613

Merged
luke- merged 5 commits into
masterfrom
fix/fix-tests
Oct 17, 2025
Merged

Fix tests#613
luke- merged 5 commits into
masterfrom
fix/fix-tests

Conversation

@yurabakhtin

Copy link
Copy Markdown
Collaborator

@yurabakhtin yurabakhtin requested a review from luke- October 16, 2025 14:09
@yurabakhtin

Copy link
Copy Markdown
Collaborator Author

@luke- I am not sure how to solve the conflict with the file composer.lock because I prefer to remove it from repo as I described here only if you don't have an important reason to keep it here.

@yurabakhtin yurabakhtin marked this pull request as ready for review October 16, 2025 20:07
@yurabakhtin

yurabakhtin commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator Author

@luke- Here I see you wrote:

Hint: Make sure to always commit the composer.lock as well.

Ok, I will try again to commit the file to see how tests works again.


After merging new changes from master all tests work well even with the composer.lock, so ok let's keep it as before.
This PR is ready for merging.

@luke- luke- merged commit 633dabf into master Oct 17, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants