Skip to content

Fix: save_profile_settings drops every site after the first on PHP 8 #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svandragt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: save_profile_settings drops every site after the first on PHP 8 #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions library/Falcon/Connector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,13 @@ public function save_profile_settings( $user_id, $args = array(), $sites = null
}
$value = $args[ $request_key ];

// Check the value is valid
$options = array_keys( $options );
if ( ! in_array( $value, $options ) ) {
// Check the value is valid.
// Use a fresh local so we don't mutate the outer foreach's $options —
// on subsequent sites that would leave $options as a numeric-indexed
// list, and on PHP 8+ in_array() with non-numeric strings against ints
// no longer loose-equates, so all sites after the first silently skip.
$valid_values = array_keys( $options );
if ( ! in_array( $value, $valid_values, true ) ) {
continue;
}

Expand Down