fix(show-me): use a platform-appropriate command to open the HTML file - #3
Open
JuanluTrapero wants to merge 1 commit into
Open
fix(show-me): use a platform-appropriate command to open the HTML file#3JuanluTrapero wants to merge 1 commit into
JuanluTrapero wants to merge 1 commit into
Conversation
`open` only exists on macOS, so the final step of the HTML branch fails on Linux and WSL. List the equivalent command for each platform.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML branch of
show-meends with:openis macOS-only, so on Linux the agent runs a command that does not exist, and on WSLxdg-openis usually not the right one either. The visual gets written and then never shown.This lists the equivalent per platform, keeping the existing style and staying inside the same code block. No other changes.