Update docstring about tool messages in prepare_multimodal_messages#5476
Merged
albertvillanova merged 1 commit intohuggingface:mainfrom Apr 8, 2026
Merged
Update docstring about tool messages in prepare_multimodal_messages#5476albertvillanova merged 1 commit intohuggingface:mainfrom
albertvillanova merged 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update docstring about tool messages in
prepare_multimodal_messages.Note that after #5440, messages with "tool" role are prepared for multimodal, but the docstring was not updated.
This PR includes a minor documentation update to the
prepare_multimodal_messagesfunction. The change removes a no longer applicable note about handling"tool_calls"and"tool"role in the function's docstring.Follow-up to:
_get_tool_suffix_ids#5440Changes
"tool_calls"in"assistant"turns and"tool"roles with"content"and"name"are left as-is, as these do not require special handling for multimodal data. (trl/data_utils.py)Note
Low Risk
Docstring-only change with no runtime behavior impact.
Overview
Updates the
prepare_multimodal_messagesdocstring intrl/data_utils.pyby removing an outdated note claimingtool_calls/toolrole messages are left untouched during multimodal preparation.Reviewed by Cursor Bugbot for commit 84e70e1. Bugbot is set up for automated code reviews on this repo. Configure here.