Merged
Conversation
…sages + async grpo
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
commented
Apr 7, 2026
|
|
||
| class TestIsChatTemplatePrefixPreserving: | ||
| def test_prefix_preserving_template(self): | ||
| tokenizer = AutoTokenizer.from_pretrained("trl-internal-testing/tiny-Qwen3MoeForSequenceClassification") |
Member
Author
There was a problem hiding this comment.
same template, but it's more natural to use the CausalLM instead of the SequenceClassification
Member
Author
There was a problem hiding this comment.
I can't remember why we used Qwen3MoeForSequenceClassification in the first place
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 91e940e. Configure here.
albertvillanova
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

qwen3_vl.jinjatemplate for identity matching inadd_response_schemaTestAddResponseSchemaandTestParseResponsetest parametrizationsPart of #5460
Warning
Requires/contains #5459
Note
Low Risk
Low risk: adds a new Qwen3-VL chat template and wires it into existing response-schema selection, plus test/doc updates; minimal impact outside Qwen3/Qwen3-VL parsing paths.
Overview
Adds Qwen3-VL tool-calling support by introducing a new
qwen3_vl.jinjachat template (including multimodal image/video placeholders) and treating it as Qwen3-equivalent foradd_response_schemasoparse_responsecan extract tool calls.Updates unit tests to cover Qwen3-VL parsing/schema behavior and refreshes Qwen3 test fixtures, and documents Qwen3-VL as a supported model for GRPO agent training.
Reviewed by Cursor Bugbot for commit 535544b. Bugbot is set up for automated code reviews on this repo. Configure here.