Deprecate keep_end truncation mode#5465
Merged
albertvillanova merged 6 commits intohuggingface:mainfrom Apr 7, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0361a1e. Configure here.
qgallouedec
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Deprecate "keep_end"
truncation mode.See related discussion:
This PR deprecates the
"keep_end"truncation mode in theDPOConfigandSFTConfigclasses, warning users that it will be removed in version 2.0.0. The changes update documentation, add a deprecation warning at runtime, and adjust tests to expect this warning.Changes
Deprecation of
"keep_end"truncation mode:helpmetadata for thetruncation_modeparameter inDPOConfigandSFTConfigto state that only"keep_start"is supported, and that"keep_end"is deprecated and will be removed in v2.0.0.__post_init__to emit aFutureWarningif"keep_end"is used, guiding users to switch to"keep_start".Test updates:
test_train_vlm_keep_end_raisesandtest_skip_prepare_dataset_passes_truncation_to_text_collatorto expect aFutureWarningwhen"keep_end"is used, ensuring the deprecation warning is tested.Note
Medium Risk
Behavior is backwards-compatible but introduces a new
FutureWarningthat can fail user pipelines configured to treat warnings as errors; otherwise the change is localized to config initialization and tests.Overview
DPOConfignow deprecatestruncation_mode="keep_end": docs/help text were updated to statekeep_startis the only supported mode, and usingkeep_endemits aFutureWarningindicating it will be removed in v2.0.0.Tests were updated to assert the new deprecation warning is raised when initializing
DPOConfigwithkeep_end(while still expecting the existing VLMValueErrorguard).Reviewed by Cursor Bugbot for commit 0361a1e. Bugbot is set up for automated code reviews on this repo. Configure here.