[docs] Clarify dtype defaults between trf v5 and TRL#5457
Open
casinca wants to merge 1 commit intohuggingface:mainfrom
Open
[docs] Clarify dtype defaults between trf v5 and TRL#5457casinca wants to merge 1 commit intohuggingface:mainfrom
casinca wants to merge 1 commit intohuggingface:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This should Fix #5329
Feel free to tweak to your liking
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
Note
Low Risk
Low risk documentation-only change that clarifies dtype inference/default behavior; no runtime code paths are modified.
Overview
Adds a note to
docs/source/customization.mdclarifying that Transformers v5from_pretrainednow infersdtypefrom the model config (rather than defaulting tofloat32), and advising users to passdtypeexplicitly when needed.Also documents that when TRL loads models from a model name string, it still defaults to
float32.Reviewed by Cursor Bugbot for commit 17bc1da. Bugbot is set up for automated code reviews on this repo. Configure here.