Skip to content

fix _get_per_token_logps_and_entropies return type #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kashif wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix _get_per_token_logps_and_entropies return type #5456

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08c44a1
Change return type from dict to tuple in _get_per_token_logps_and_ent…
kashif Apr 4, 2026
3c3f0db
Change return type from dict to tuple in rloo_trainer
kashif Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion trl/trainer/grpo_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ def _get_per_token_logps_and_entropies(
mm_token_type_ids=None,
pixel_position_ids=None,
image_position_ids=None,
) -> dict[str, torch.Tensor | None]:
) -> tuple[torch.Tensor, torch.Tensor | None]:
"""Compute log-probs and (optionally) entropies for each token."""
batch_size = batch_size or input_ids.size(0) # Chunk inputs into smaller batches to reduce memory peak
all_logps = []
Expand Down
Loading