Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
This is a port of https://github.com/qwenpilot/FIPO as a GRPOTrainer loss function.
Additional manual validation outside the committed test suite:
AI-MO/NuminaMath-TIRnum_iterations > 1, FIPO’s inner reuse steps show nonzerolog_ratio, nonzero Future-KL, and influence weights that move away from1.0, indicating that the FIPO-specific reweighting path is activeBefore submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Note
Medium Risk
Adds a new GRPO loss implementation and associated hyperparameters, which can materially change training dynamics and stability for users selecting
loss_type="fipo". Core loss computation/masking paths are modified (vialoss_mask), so regressions could affect loss normalization and metrics across loss types.Overview
Adds FIPO (Future-KL Influenced Policy Optimization) as a new
GRPOTrainerloss_type, computing discounted Future-KL influence weights to reweight token advantages and applying FIPO-specific dual clipping and sequence/token masking.Extends
GRPOConfigwith FIPO hyperparameters and validations, adds warnings/incompatibility checks (e.g.,importance_sampling_levelignored; no Liger support), logs newfipo/*training metrics, updates tests to cover the new loss type, and documents an example FIPO recipe in the paper index.Written by Cursor Bugbot for commit 1d65c2f. This will update automatically on new commits. Configure here.