Skip to content

Skip redundant forward pass for on-policy vLLM importance sampling #5413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GJ98 wants to merge 3 commits into
base: main
Choose a base branch
from
+90 −14

fix: store old_per_token_logps and IS ratio in inputs for num_iterati…

1960957
Select commit
Loading
Failed to load commit list.
Open

Skip redundant forward pass for on-policy vLLM importance sampling #5413

fix: store old_per_token_logps and IS ratio in inputs for num_iterati…
1960957
Select commit
Loading
Failed to load commit list.
Cursor / Cursor Bugbot completed Apr 1, 2026 in 23m 44s

Bugbot Review

Bugbot Analysis Progress (23m 46s elapsed)

✅ Gathered PR context (2s)
✅ Completed bug detection (23m 36s)
✅ Posted analysis results (8s)

Final Result: Bugbot completed review and found 1 potential issue. 2 previously reported issues remain unresolved.

Request ID: serverGenReqId_ed41ce2e-5af5-40bd-836a-e911844dd7bb

Details

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

View more details on Cursor