Add log_multimodal param to GRPOConfig and RLOOConfig to control image logging#5408
Open
apardyl wants to merge 3 commits intohuggingface:mainfrom
Open
Add log_multimodal param to GRPOConfig and RLOOConfig to control image logging#5408apardyl wants to merge 3 commits intohuggingface:mainfrom
log_multimodal param to GRPOConfig and RLOOConfig to control image logging#5408apardyl wants to merge 3 commits intohuggingface:mainfrom
Conversation
log_multimodal param to GRPOConfig to control image logginglog_multimodal param to GRPOConfig and RLOOConfig to control image logging
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
This PR introduces a
log_multimodaloption to GRPOConfig and RLOOConfig, which controls whether multimodal data is logged alongside completions.When multiple high-resolution images are used during training, the log can quickly grow in size. While viewing images together with completions is very useful for debugging, disabling this feature for longer training runs can significantly reduce (cloud) storage usage.
The log_multimodal option defaults to True, preserving the current behavior.
Before submitting
AI writing disclosure
We welcome the use of AI tools to help with contributions. For transparency and to help us improve our review process, please indicate the level of AI involvement in this PR.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.
Note
Low Risk
Low risk: gated logging-only behavior change with default preserving existing output, affecting only whether image data is gathered/stored in completion logs.
Overview
Adds a new
log_multimodaloption toGRPOConfigandRLOOConfig(defaultTrue) to control whether images/multimodal payloads are included in completion logging.Updates
GRPOTrainerandRLOOTrainerto honor this flag by skipping theimagesgather/append step when disabled, reducing log size for high-resolution multimodal training runs.Written by Cursor Bugbot for commit 9dbbd3c. This will update automatically on new commits. Configure here.