Draft
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
reviewed
Apr 9, 2026
Comment on lines
+55
to
+59
| -@auto_docstring(checkpoint="allenai/OLMo-7B-hf") | ||
| +@auto_docstring(checkpoint="allenai/Olmo2-7B-1124-hf") | ||
| +@strict | ||
| -class OlmoConfig(PreTrainedConfig): | ||
| +class Olmo2Config(OlmoConfig): |
Member
There was a problem hiding this comment.
nice, i was pointed out just recently that docs aren;t up-to-date with config changes 😄
Contributor
|
Hi @stevhliu , if I may, would it be possible to add somewhere what Matt said in #45141 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactors the how to add a model with modular transformers doc:
structure:
super()sections with context on when to use eachmissing features:
@strict,__post_init__,__all__,AttributeError(),base_model_tp_plan,base_model_pp_planupdates:
### Configsection with new patterns like__post_init__,AttributeError()and class-level type annotations for new attributessuper_kwargsexample referencesGemmaForCausalLMnowlet me know if there are other commonly missed modular practices!
todo: