Add docstring to FFN.forward in DistilBERT#45267
Open
KetanP1618 wants to merge 1 commit intohuggingface:mainfrom
Open
Add docstring to FFN.forward in DistilBERT#45267KetanP1618 wants to merge 1 commit intohuggingface:mainfrom
KetanP1618 wants to merge 1 commit intohuggingface:mainfrom
Conversation
- Added Args and Returns sections to FFN.forward method - FFN.forward previously had no documentation - Improves documentation coverage for DistilBERT model
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: distilbert |
Member
|
Same comment as #45266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a missing docstring to the
FFN.forwardmethod in DistilBERT.The
FFN.forwardmethod inmodeling_distilbert.pyhad no documentationat all. This PR adds proper Args and Returns sections following the
existing Hugging Face docstring format.
Changes
FFN.forward- Added Args and Returns sectionsTests
Verified the class works correctly:
FFNoutput shape:torch.Size([2, 10, 768])