Add docstrings to AlbertMLMHead and AlbertSOPHead forward methods#45266
Open
KetanP1618 wants to merge 1 commit intohuggingface:mainfrom
Open
Add docstrings to AlbertMLMHead and AlbertSOPHead forward methods#45266KetanP1618 wants to merge 1 commit intohuggingface:mainfrom
KetanP1618 wants to merge 1 commit intohuggingface:mainfrom
Conversation
- Added Args and Returns sections to AlbertMLMHead.forward - Added Args and Returns sections to AlbertSOPHead.forward - Improves documentation coverage for ALBERT model heads
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: albert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds missing docstrings to two undocumented
forwardmethods in the ALBERT model:AlbertMLMHead.forward- Added Args and Returns sectionsAlbertSOPHead.forward- Added Args and Returns sectionsBoth methods previously had no documentation at all. This improves
documentation coverage for ALBERT model heads and helps users
understand the expected inputs and outputs.
Tests
Verified both classes work correctly:
AlbertMLMHeadoutput shape:torch.Size([2, 10, 30000])AlbertSOPHeadoutput shape:torch.Size([2, 2])