Skip to content

fix: restore mypy type checking for PreTrainedConfig subclasses (#45071) #45240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shhKnight30 wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −0
Open

fix: restore mypy type checking for PreTrainedConfig subclasses (#45071) #45240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fccb693
fix: restore mypy type checking for PreTrainedConfig subclasses (#45071)
shhKnight30 Apr 4, 2026
a38c42b
Merge branch 'main' into fix-type-checking-issue
shhKnight30 Apr 4, 2026
f2ca399
Merge branch 'main' into fix-type-checking-issue
shhKnight30 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/transformers/configuration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from huggingface_hub import create_repo
from huggingface_hub.dataclasses import strict
from packaging import version
from typing_extensions import dataclass_transform

from . import __version__
from .dynamic_module_utils import custom_object_save
Expand Down Expand Up @@ -75,6 +76,8 @@

# copied from huggingface_hub.dataclasses.strict when `accept_kwargs=True`
def wrap_init_to_accept_kwargs(cls: dataclass):

# Get the original dataclass-generated __init__
original_init = cls.__init__

@wraps(original_init)
Expand Down Expand Up @@ -113,6 +116,7 @@ def __init__(self, *args, **kwargs: Any) -> None:
return cls


@dataclass_transform(kw_only_default=True)
@strict(accept_kwargs=True)
@dataclass(repr=False)
class PreTrainedConfig(PushToHubMixin, RotaryEmbeddingConfigMixin):
Expand Down
Loading