Fix: ObjectDetectionPipeline batch inference only returns first image results#45223
Open
Talhax55z wants to merge 2 commits intohuggingface:mainfrom
Open
Fix: ObjectDetectionPipeline batch inference only returns first image results#45223Talhax55z wants to merge 2 commits intohuggingface:mainfrom
Talhax55z wants to merge 2 commits intohuggingface:mainfrom
Conversation
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=45223&sha=1d9b99 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31356
What does this PR do?
The
postprocessmethod inObjectDetectionPipelinewas hardcodingraw_annotations[0], which caused batch inference to only returnresults for the first image, ignoring all others.
This PR replaces the single-item access with a loop over all
raw_annotations, so every image in a batch gets processed correctly.Changes
src/transformers/pipelines/object_detection.py: replacedraw_annotation = raw_annotations[0]with a for loop overall annotations
I confirm that this is not a pure code agent PR.
@Rocketknight1