Skip to content

[CLI] Space hot-reload: wait for up-to-date infos #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbensimon wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −1
Open

[CLI] Space hot-reload: wait for up-to-date infos #4049

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a023dd4
[CLI] Space hot-reload: wait for up-to-date infos
cbensimon Apr 3, 2026
dd2c0ea
Assert parent commit when possible
cbensimon Apr 3, 2026
2751eae
Update src/huggingface_hub/cli/spaces.py
cbensimon Apr 7, 2026
0cfb780
Increase httpx timeout from 5s (default) to 10s
cbensimon Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/huggingface_hub/cli/spaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,10 @@ def spaces_hot_reload(
raise CLIError(f"Unable to read sdk_version from {space_id} cardData")
if version.parse(sdk_version) < version.Version(HOT_RELOADING_MIN_GRADIO):
raise CLIError(f"Hot-reloading requires Gradio >= {HOT_RELOADING_MIN_GRADIO} (found {sdk_version})")
if (current_sha := space_info.sha) is None:
raise CLIError(f"Unexpected `None` running SHA for Space {space_id}")
else:
current_sha = None

if local_file:
local_path = local_file
Expand Down Expand Up @@ -329,6 +333,7 @@ def spaces_hot_reload(
_spaces_hot_reload_summary(
api=api,
space_id=space_id,
current_sha=current_sha,
commit_sha=commit_info.oid,
local_path=local_path if local_file else os.path.basename(local_path),
token=token,
Expand All @@ -338,11 +343,18 @@ def spaces_hot_reload(
def _spaces_hot_reload_summary(
api: HfApi,
space_id: str,
current_sha: str | None,
commit_sha: str,
local_path: str | None,
token: str | None,
) -> None:
space_info = api.space_info(space_id)
while (space_info := api.space_info(space_id)).sha == current_sha:
if current_sha is None:
break
typer.secho("Waiting for up-to-date Space infos", fg=typer.colors.BRIGHT_BLACK)
time.sleep(2)
Copy link
Copy Markdown

@cursor cursor bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StatusLine not finalized after polling loop exits

Low Severity

After the while polling loop exits, status.done(...) is never called. StatusLine.update() writes to stderr without a trailing newline, so if the loop ran at least once, subsequent output (from typer.secho, raise CLIError, etc.) will appear on the same terminal line as the leftover "Waiting for up-to-date Space info..." message. The dev_mode function in the same file properly calls status.done(...) on every exit path from its analogous polling loop.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2751eae. Configure here.

if space_info.sha != commit_sha:
raise CLIError(f"Expected SHA {commit_sha} after hot-reload but got {space_info.sha}")
if (runtime := space_info.runtime) is None:
raise CLIError(f"Unable to read SpaceRuntime from {space_id} infos")
if (hot_reloading := runtime.hot_reloading) is None:
Expand Down
Loading