use constant of default revision instead of empty root#3682
use constant of default revision instead of empty root#3682cr-klarna wants to merge 3 commits intohuggingface:mainfrom
Conversation
|
This fixes a smaller problem, but there is still the fact that there is not really a proper static way that pathing is done when revision is not supplied, and the caching behavior is a bit wonky. Will need to work more on this to fully solve all issues, though this should be enough I think to give staff some inspiration to look into this a bit more so folks with private mirrors will be able to use the models more seamlessly |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
left a comment
There was a problem hiding this comment.
thanks @cr-klarna for the PR! indeed, explicitly including /revision/main when no revision is specified is consistent with how we handle revisions elsewhere in the codebase and it ensures compatibility with mirrors that don't implement the implicit redirect
I pushed a commit to update dataset_info and space_info as well
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3682 +/- ##
==========================================
+ Coverage 75.00% 77.50% +2.49%
==========================================
Files 145 149 +4
Lines 13978 14654 +676
==========================================
+ Hits 10484 11357 +873
+ Misses 3494 3297 -197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes #3681
As mentioned in the issue, since Transformers' latest compatible non-prerelease manifest specifies < 1.0 for huggingface_hub, I believe this should be applied to the minor versions below that as well.