Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a53ec59. Configure here.
| repoUrl: "https://github.com/nv-tlabs/lyra", | ||
| filter: false, | ||
| countDownloads: `path:"checkpoints/image_encoder/model.pth"`, | ||
| }, |
There was a problem hiding this comment.
New entry breaks alphabetical ordering convention
Low Severity
The lyra entry is inserted between k2 and lagernvs, placing it at the very beginning of the "l" section. Alphabetically, ly sorts after la, le, li, and ll, so lyra belongs near the end of the "l" entries (after liveportrait, before llama-cpp-python). This makes the entry harder to locate for future maintainers.
Reviewed by Cursor Bugbot for commit a53ec59. Configure here.
|
Fixed the entry (missing brace). Are model checkpoints upcoming Merve? |
| repoName: "k2", | ||
| repoUrl: "https://github.com/k2-fsa/k2", | ||
| }, | ||
| lyra: { |
There was a problem hiding this comment.
Will it cover both https://huggingface.co/nvidia/Lyra and https://huggingface.co/nvidia/Lyra-2.0 ? It yes, then the download count rule is not correct. If it's only for the Lyra 2.0 release then should we tag the library as lyra-2.0 instead?
(also fine to keep it as-is if you think it'd best, I don't have the full picture)


Note
Low Risk
Low risk: adds a new static entry to the model libraries registry, only affecting library tagging/display and download-count query matching for
lyramodels.Overview
Adds
lyratoMODEL_LIBRARIES_UI_ELEMENTS, exposing the Lyra repo metadata in the model library UI and enabling download counting via an Elastic query targetingcheckpoints/image_encoder/model.pth.Reviewed by Cursor Bugbot for commit a53ec59. Bugbot is set up for automated code reviews on this repo. Configure here.