Skip to content

add lyra as library#2108

Open
merveenoyan wants to merge 3 commits intomainfrom
add-lyra
Open

add lyra as library#2108
merveenoyan wants to merge 3 commits intomainfrom
add-lyra

Conversation

@merveenoyan
Copy link
Copy Markdown
Contributor

@merveenoyan merveenoyan commented Apr 17, 2026

Note

Low Risk
Low risk: adds a new static entry to the model libraries registry, only affecting library tagging/display and download-count query matching for lyra models.

Overview
Adds lyra to MODEL_LIBRARIES_UI_ELEMENTS, exposing the Lyra repo metadata in the model library UI and enabling download counting via an Elastic query targeting checkpoints/image_encoder/model.pth.

Reviewed by Cursor Bugbot for commit a53ec59. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread packages/tasks/src/model-libraries.ts
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a53ec59. Configure here.

repoUrl: "https://github.com/nv-tlabs/lyra",
filter: false,
countDownloads: `path:"checkpoints/image_encoder/model.pth"`,
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New entry breaks alphabetical ordering convention

Low Severity

The lyra entry is inserted between k2 and lagernvs, placing it at the very beginning of the "l" section. Alphabetically, ly sorts after la, le, li, and ll, so lyra belongs near the end of the "l" entries (after liveportrait, before llama-cpp-python). This makes the entry harder to locate for future maintainers.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a53ec59. Configure here.

@pcuenca
Copy link
Copy Markdown
Member

pcuenca commented Apr 17, 2026

Fixed the entry (missing brace). Are model checkpoints upcoming Merve?

repoName: "k2",
repoUrl: "https://github.com/k2-fsa/k2",
},
lyra: {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it cover both https://huggingface.co/nvidia/Lyra and https://huggingface.co/nvidia/Lyra-2.0 ? It yes, then the download count rule is not correct. If it's only for the Lyra 2.0 release then should we tag the library as lyra-2.0 instead?

(also fine to keep it as-is if you think it'd best, I don't have the full picture)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants