feat(tasks): count Hub downloads for NVIDIA Ising Decoding (safetensors)#2101
Conversation
Register library key ising-decoding (Hub library_name) with countDownloads on path_extension safetensors so direct checkpoint GET/HEAD is counted. Each HF model repo ships a single weights file. Signed-off-by: kvmto <kmato@nvidia.com>
kvmto
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
merveenoyan
left a comment
merveenoyan
left a comment
There was a problem hiding this comment.
I'd keep it to ising and tag other parts or upcoming models like that!
Co-authored-by: Merve Noyan <merve@huggingface.co>
Co-authored-by: Merve Noyan <merve@huggingface.co>
Co-authored-by: Merve Noyan <merve@huggingface.co>
| }, | ||
| "ising": { | ||
| prettyLabel: "Ising", | ||
| repoName: "Ising-Decoding",```suggestion |
There was a problem hiding this comment.
I suspect the "```suggestion" wasn't an intentional addition?
Signed-off-by: kvmto <kmato@nvidia.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7abbc89. Configure here.
@kvmto I had an offline conversation with @merveenoyan. There may have been a misunderstanding about which models would be upcoming and whether or not we'd want to track them together. We don't want other non-decoding Ising models to get lumped in with our download counts, so could we please go back to including "-decoding" (or "-Decoding") in all the names? |
|
(just a reminder that https://huggingface.co/models?other=ising-decoding must be populated with at least 1 model before merging this PR) |
We ultimately want to get download counters on https://huggingface.co/nvidia/Ising-Decoder-SurfaceCode-1-Fast and https://huggingface.co/nvidia/Ising-Decoder-SurfaceCode-1-Accurate. @kvmto can correct me if I'm wrong, but I think the thought was that we could update the client code to put the "ising-decoding" somewhere in the request, and that would tell the HF servers to count the download. Is that not the right way? Your comment about populating https://huggingface.co/models?other=ising-decoding on the server side makes me think that my understanding is actually incorrect. |
Hi @Wauplin just to clarify, should I add library_name: ising-decoding to the YAML frontmatter of the two ising decoding models READMEs? |
Yes exactly, that's the way to go! |
done! https://huggingface.co/nvidia/Ising-Decoder-SurfaceCode-1-Fast/blob/main/README.md https://huggingface.co/nvidia/Ising-Decoder-SurfaceCode-1-Accurate/blob/main/README.md |
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
All good, thank you! Expect 2-3 working days before getting it live on the Hub 🤗
4 participants
Summary
Registers NVIDIA Ising Decoding on the Hub so
.safetensorsweight downloads are counted in model download stats.Problem
Decoder weights are shipped as standalone
.safetensorscheckpoints. Without alibrary_name→countDownloadsmapping, those requests may not show up in download metrics the way library-specific “query files” do.Change
ising-decodingtopackages/tasks/src/model-libraries.ts.countDownloads:path_extension:"safetensors".repoUrl: https://github.com/NVIDIA/Ising-DecodingEach current model repo ships one weight file, so this should align one download with one counted request.
Hub follow-up (required)
For stats to apply, model metadata must set:
library_name: ising-decoding(the key must match the
MODEL_LIBRARIES_UI_ELEMENTSentry exactly).Example repos:
References
Note for reviewers
If repos under this
library_namelater add multiple.safetensorsfiles, consider tighteningcountDownloads(explicit paths or a regexp) to avoid double counting; happy to follow up.Note
Low Risk
Low risk: adds a single new
library_namemapping used for download counting, with no changes to runtime logic beyond an additional Elasticsearch query definition.Overview
Registers the new model library key
ising-decodinginmodel-libraries.ts, including repo metadata and acountDownloadsquery to count.safetensorsweight downloads for models using thislibrary_name.Reviewed by Cursor Bugbot for commit 896ad32. Bugbot is set up for automated code reviews on this repo. Configure here.