fix: validate cached tokens during client initialization#33
Open
prabhakarpujeri wants to merge 1 commit intohuggingface:mainfrom
Open
fix: validate cached tokens during client initialization#33prabhakarpujeri wants to merge 1 commit intohuggingface:mainfrom
prabhakarpujeri wants to merge 1 commit intohuggingface:mainfrom
Conversation
Previously, only explicitly provided tokens were validated during DellAIClient initialization. Tokens loaded from the Hugging Face cache were used without validation, which could cause silent failures when users had expired or invalid cached tokens. This change ensures all tokens are validated regardless of source, providing immediate feedback when authentication credentials are invalid. Fixes huggingface#29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Previously, only explicitly provided tokens were validated during
DellAIClientinitialization. Tokens loaded from the Hugging Face cache were used without validation, causing silent failures when users had expired or invalid cached tokens.Solution
Changed the validation logic in
client.py:48-55to validate all tokens regardless of source (explicit or cached).Changes
dell_ai/client.py- Validate all tokens, not just explicit onestests/unit/test_client.py- Added 2 new tests:test_initialization_with_invalid_cached_tokentest_initialization_with_valid_cached_tokenTest plan
AuthenticationErrorFixes #29