Skip to content

fix(FSDP2): auto-wrap policy ignoring _no_split_modules fallback #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohnGiorgi wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix(FSDP2): auto-wrap policy ignoring _no_split_modules fallback #3999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10a5275
fix: FSDP2 auto-wrap policy ignores _no_split_modules fallback
JohnGiorgi Apr 7, 2026
b08069b
remove repro script (will go in PR description)
JohnGiorgi Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/accelerate/utils/fsdp_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,7 +790,7 @@ def fsdp2_prepare_auto_wrap_policy(fsdp2_plugin, model: torch.nn.Module) -> Call
transformer_cls_to_wrap.add(transformer_cls)

def policy(module: torch.nn.Module) -> bool:
if fsdp2_plugin.transformer_cls_names_to_wrap is None:
if not transformer_cls_to_wrap:
return False
return isinstance(module, tuple(transformer_cls_to_wrap))

Expand Down