Security: Unverified remote wheel installation enables supply-chain compromise#3998
Open
tuanaiseo wants to merge 1 commit intohuggingface:mainfrom
Conversation
…es suppl The helper installs `torch_xla` directly from a remote URL using `pip install` without pinning a hash/signature. If the wheel source is tampered with, users can execute attacker-controlled code during installation. Affected files: torch_xla.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The helper installs
torch_xladirectly from a remote URL usingpip installwithout pinning a hash/signature. If the wheel source is tampered with, users can execute attacker-controlled code during installation.Severity:
highFile:
src/accelerate/utils/torch_xla.pySolution
Avoid direct unauthenticated wheel URLs. Pin exact versions and hashes (e.g.,
--require-hashes), prefer trusted indexes, and verify provenance/signatures before installation.Changes
src/accelerate/utils/torch_xla.py(modified)Testing