Send images per message in Ollama chat requests - #199
Merged
Conversation
OllamaLanguageModel attached base64 images at the top level of the /api/chat request body, but the endpoint only reads images from the messages themselves, so image input was silently dropped and vision models responded as if no image was provided. Move images onto OllamaMessage and drop the unused top-level field. Adds request-encoding tests that run without a live Ollama server. Fixes huggingface#167
Collaborator
|
Merging now. Thanks, @james-333i! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OllamaLanguageModel attached base64 images at the top level of the /api/chat request body, but the endpoint only reads images from the messages themselves, so image input was silently dropped and vision models responded as if no image was provided.
Move images onto OllamaMessage and drop the unused top-level field. Adds request-encoding tests that run without a live Ollama server.
Fixes #167
Resubmitted after an accidental force push closed #183.