ci: remove the per-PR image size-diff comment#1556
Merged
Conversation
The size-diff compared each PR build's compressed layers against :rolling and posted a comment. For a third-party-app repackaging repo the delta is almost always upstream-driven (not actionable), and most app PRs are Renovate version bumps, so the comment was noise — at the cost of a second per-PR OCI bake, a workflow_run follow-up run, and a dangerous-trigger surface. Removes the Export OCI / App Size Diff / Save / Upload steps, the app-size-diff action, the size-diff-comment.yaml workflow, and its zizmor dangerous-trigger suppression. Fork-PR build+test (type=docker load + app-tests on PRs) is unaffected. regctl stays in mise (used by retry-release.yaml).
The app-tests composite action declared a required 'token' input but only ever uses app + image (go test ./apps/$APP/...). Remove the input, its description, and the github.token passed by app-builder so the action's interface is honest. No behavior change; Run App Tests is PR-only and github.token remains used by the login/release jobs.
Signed-off-by: Devin Buhl <onedr0p@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The size-diff (introduced via #1553, building on the pre-existing comment) measured each PR build's compressed layers against
:rollingand posted a comment. In practice it's low signal for this repo:0 B/ trivial-delta noise on bot PRs.…and it isn't free: a second
type=ocibake on every amd64 PR leg, aworkflow_runfollow-up run per PR, adangerous-triggersurface (with a zizmor suppression), and two bugs already (#1553 startup_failure, #1555 download-layout miss).What
Removes only the size-diff:
app-builder.yaml: drop the Export OCI Image / App Size Diff / Save Size Diff / Upload Size Diff stepsapp-size-diffcomposite actionsize-diff-comment.yamlworkflow_runworkflowdangerous-triggerssuppression from.github/zizmor.ymlWhat stays
type=docker(load:sandboxlocally) and run app-tests in-job, no push/secrets — unchanged.regctlstays in mise (still used byretry-release.yaml).zizmor clean; no remaining references to any removed piece.