Skip to content

ci(size-diff): post comment when the artifact extracts flat (single app) #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onedr0p merged 1 commit into from
Jun 29, 2026
Merged

ci(size-diff): post comment when the artifact extracts flat (single app) #1555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/size-diff-comment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,12 +56,20 @@ jobs:
return;
}

for (const entry of fs.readdirSync(dir)) {
const sub = path.join(dir, entry);
if (!fs.statSync(sub).isDirectory()) continue;
// A single matching artifact extracts flat into DIR; multiple land
// in per-artifact subdirs. Handle both: DIR itself + its subdirs.
const candidates = [dir, ...fs.readdirSync(dir)
.map(e => path.join(dir, e))
.filter(p => fs.statSync(p).isDirectory())];

const app = fs.readFileSync(path.join(sub, "app"), "utf8").trim();
const body = fs.readFileSync(path.join(sub, "body.md"), "utf8");
let posted = 0;
for (const sub of candidates) {
const appPath = path.join(sub, "app");
const bodyPath = path.join(sub, "body.md");
if (!fs.existsSync(appPath) || !fs.existsSync(bodyPath)) continue;

const app = fs.readFileSync(appPath, "utf8").trim();
const body = fs.readFileSync(bodyPath, "utf8");
if (!app || !body) continue;
if (!body.startsWith("## 📦 App Size Analysis")) {
core.warning(`Skipping ${app}: unexpected size-diff body.`);
Expand Down Expand Up @@ -93,4 +101,7 @@ jobs:
body: fullBody,
});
}
posted++;
}

if (!posted) core.warning("No size-diff payloads found under the artifact dir.");