victron_gx: Bump victron-mqtt to 2026.9.2 - #181452
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Two moderate dependency-integration issues must be resolved before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Bumps victron-mqtt to 2026.9.1 and adds translations for new Victron GX entities.
Changes:
- Updates the integration and generated dependency pins.
- Adds number, sensor, and firmware-state translations.
File summaries
| File | Description |
|---|---|
requirements_all.txt |
Updates the generated dependency pin. PR-template comments must be restored. |
homeassistant/components/victron_gx/strings.json |
Adds translations for new metrics. |
homeassistant/components/victron_gx/manifest.json |
Updates the dependency; requires an upstream firmware-progress unit fix and propagation of Metric.available with regression coverage. |
Review details
Suppressed comments (1)
requirements_all.txt:3385
- Restore the untouched PR-template comments in the pull request description. The current description removes all required HTML comment blocks, while this repository requires every template element except the optional Breaking change section to remain present.
victron-mqtt==2026.9.1
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🔵 Needs a closer look
Firmware progress must report % upstream, followed by a bump to the fixed release.
Review details
Suppressed comments (1)
homeassistant/components/victron_gx/manifest.json:10
- Use a
victron-mqttrelease that reports%for firmware progress. The newplatform_venus_firmware_progressdescriptor isMetricType.PERCENTAGEbut has nounit_of_measurement;VictronSensorhas no device-class mapping for that type and only forwards units supplied by the metric, so Home Assistant will expose values such as50without%. Please addunit_of_measurement="%"upstream and bump to the fixed release.
"requirements": ["victron-mqtt==2026.9.1"],
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Update the PR metadata and comparison link to match the pinned 2026.9.2 release, or restore the 2026.9.1 pin.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Buttons must inherit metric availability so unavailable endpoints are not presented as actionable.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 1
- Review effort level: Balanced
Proposed change
Bump
victron-mqttlibrary from2026.8.4to2026.9.2for thevictron_gxintegration.Changes include:
victron-mqttdependency version inmanifest.jsonand requirements filesstrings.json) from latest topic definitionsAnyfor metric values anymore but the newMetricValue. This was just changed here to make linter happy with this change.Noneas value meant that the entity is unavailable and now it is tracked via specific new property so without this small tweak this version bump would break that scenario. This change already works for good few weeks on the custom integration and verified by users.Changelog: tomer-w/victron_mqtt@v2026.8.4...v2026.9.2
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: