Skip to content

victron_gx: Bump victron-mqtt to 2026.9.2 - #181452

Merged
erwindouna merged 4 commits into
home-assistant:devfrom
tomer-w:victron-gx/bump-2026.9.1
Sep 6, 2026
Merged

victron_gx: Bump victron-mqtt to 2026.9.2#181452
erwindouna merged 4 commits into
home-assistant:devfrom
tomer-w:victron-gx/bump-2026.9.1

Conversation

@tomer-w

@tomer-w tomer-w commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Proposed change

Bump victron-mqtt library from 2026.8.4 to 2026.9.2 for the victron_gx integration.

Changes include:

  • Update victron-mqtt dependency version in manifest.json and requirements files
  • Specifically, this version includes the needed support needed to implement firmware update support.
  • Update entity translations (strings.json) from latest topic definitions
  • Minor changes in types as the library is not using Any for metric values anymore but the new MetricValue. This was just changed here to make linter happy with this change.
  • I had to add support for metric availability as in the old victron-mqtt library getting back None as value meant that the entity is unavailable and now it is tracked via specific new property so without this small tweak this version bump would break that scenario. This change already works for good few weeks on the custom integration and verified by users.

Changelog: tomer-w/victron_mqtt@v2026.8.4...v2026.9.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings September 6, 2026 13:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two moderate dependency-integration issues must be resolved before approval.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Bumps victron-mqtt to 2026.9.1 and adds translations for new Victron GX entities.

Changes:

  • Updates the integration and generated dependency pins.
  • Adds number, sensor, and firmware-state translations.
File summaries
File Description
requirements_all.txt Updates the generated dependency pin. PR-template comments must be restored.
homeassistant/components/victron_gx/strings.json Adds translations for new metrics.
homeassistant/components/victron_gx/manifest.json Updates the dependency; requires an upstream firmware-progress unit fix and propagation of Metric.available with regression coverage.
Review details

Suppressed comments (1)

requirements_all.txt:3385

  • Restore the untouched PR-template comments in the pull request description. The current description removes all required HTML comment blocks, while this repository requires every template element except the optional Breaking change section to remain present.
victron-mqtt==2026.9.1
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread homeassistant/components/victron_gx/manifest.json Outdated
Comment thread homeassistant/components/victron_gx/manifest.json Outdated
Copilot AI review requested due to automatic review settings September 6, 2026 14:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Firmware progress must report % upstream, followed by a bump to the fixed release.

Review details

Suppressed comments (1)

homeassistant/components/victron_gx/manifest.json:10

  • Use a victron-mqtt release that reports % for firmware progress. The new platform_venus_firmware_progress descriptor is MetricType.PERCENTAGE but has no unit_of_measurement; VictronSensor has no device-class mapping for that type and only forwards units supplied by the metric, so Home Assistant will expose values such as 50 without %. Please add unit_of_measurement="%" upstream and bump to the fixed release.
  "requirements": ["victron-mqtt==2026.9.1"],
  • Files reviewed: 7/7 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

Copilot AI review requested due to automatic review settings September 6, 2026 14:48
@tomer-w tomer-w changed the title Bump victron-mqtt to 2026.9.1 victron_gx: Bump victron-mqtt to 2026.9.2 Sep 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Update the PR metadata and comparison link to match the pinned 2026.9.2 release, or restore the 2026.9.1 pin.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread homeassistant/components/victron_gx/manifest.json
Copilot AI review requested due to automatic review settings September 6, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Buttons must inherit metric availability so unavailable endpoints are not presented as actionable.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 10/10 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread homeassistant/components/victron_gx/button.py
@tomer-w
tomer-w marked this pull request as ready for review September 6, 2026 15:24

@erwindouna erwindouna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomer-w!

@erwindouna
erwindouna merged commit 8827dbb into home-assistant:dev Sep 6, 2026
53 checks passed
@tomer-w
tomer-w deleted the victron-gx/bump-2026.9.1 branch September 6, 2026 20:18
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants