Add Steinway & Lyngdorf virtual integration - #181432
Conversation
The P100, P200 and P300 processors are made by Lyngdorf and sold under the Steinway & Lyngdorf brand. They are supported by the lyngdorf integration, and are discovered by it since their SSDP manufacturer string was added, but a user looking for the brand they bought does not find it. This adds the brand as a virtual integration pointing at lyngdorf.
There was a problem hiding this comment.
🟢 Approval recommended
The manifest follows established virtual-integration conventions and the generated metadata matches it.
Pull request overview
Adds a virtual Steinway & Lyngdorf integration that redirects users to the existing Lyngdorf integration.
Changes:
- Adds the virtual integration manifest.
- Regenerates integration metadata.
File summaries
| File | Description |
|---|---|
homeassistant/components/steinway_lyngdorf/manifest.json |
Defines the virtual integration and Lyngdorf mapping. |
homeassistant/generated/integrations.json |
Registers the generated integration metadata. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The mypy CI step scopes itself to changed integrations and fails with "There are no .py[i] files in directory" when a component has none. This matches how the other virtual integrations are laid out.
|
Merge order: this needs the brand images in home-assistant/brands#11111 to land first, otherwise the integration appears without a logo. Documentation is in home-assistant/home-assistant.io#47930. |
EetuPelkonen
left a comment
There was a problem hiding this comment.
Shape looks right: supported_by: lyngdorf resolves to a real integration, integrations.json is regenerated, and the docs PR is linked. The init.py matches what most virtual integrations ship (115 of the 139 in tree have one). Nothing missing that I can see.
Proposed change
The Steinway & Sons P100, P200 and P300 surround processors are made by Lyngdorf
and sold under the Steinway & Lyngdorf brand. They are supported by the
lyngdorfintegration, and have been discoverable since #181032 added theirSteinway LyngdorfSSDP manufacturer string, but a user searching for the brandprinted on their processor finds nothing.
This adds the brand as a virtual integration pointing at
lyngdorf, so thebrand appears in the integrations list and leads to the right config flow. No
code, no tests: the manifest plus the regenerated
integrations.json.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: