Skip to content

Fix cloud support package snapshots with verbose logging #181399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justanotherariel merged 2 commits into from
Sep 8, 2026
Merged

Fix cloud support package snapshots with verbose logging #181399

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d0221d
Fix cloud support package snapshots with verbose logging
JamieMagee Sep 5, 2026
1645ef0
Use bounded log queues in cloud support package tests
JamieMagee Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/components/cloud/test_http_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2925,9 +2925,13 @@ async def test_download_support_package_custom_components_error(
aioclient_mock: AiohttpClientMocker,
freezer: FrozenDateTimeFactory,
snapshot: SnapshotAssertion,
caplog: pytest.LogCaptureFixture,
) -> None:
"""Test download support package when async_get_custom_components fails."""

# Exclude setup logs with nondeterministic timestamps in verbose runs.
caplog.set_level(logging.INFO, logger="hass_nabucasa.events.bus")

aioclient_mock.get("https://cloud.bla.com/status", text="")
Comment thread
JamieMagee marked this conversation as resolved.
Outdated
aioclient_mock.get(
"https://cert-server/directory", exc=Exception("Unexpected exception")
Expand Down Expand Up @@ -3044,9 +3048,13 @@ async def test_download_support_package_integration_load_error(
aioclient_mock: AiohttpClientMocker,
freezer: FrozenDateTimeFactory,
snapshot: SnapshotAssertion,
caplog: pytest.LogCaptureFixture,
) -> None:
"""Test download support package when async_get_loaded_integration fails."""

# Exclude setup logs with nondeterministic timestamps in verbose runs.
caplog.set_level(logging.INFO, logger="hass_nabucasa.events.bus")

aioclient_mock.get("https://cloud.bla.com/status", text="")
aioclient_mock.get(
"https://cert-server/directory", exc=Exception("Unexpected exception")
Expand Down
Loading