mosquitto: disable auth_plugin_deny_special_chars to allow '/' in client ids (#4564)#4565
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughVersion 7.0.1 release fixes a regression where client IDs containing forward slashes were rejected by ACL rules after the Mosquitto 2.1 upgrade. The fix disables special character denial in the authentication plugin configuration while updating the manifest version. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sairon
left a comment
There was a problem hiding this comment.
Nice catch, thanks for the fix!
Summary by CodeRabbit
govee2mqtt) were incorrectly rejected with "ACL denying access to client with dangerous client id" error following the Mosquitto 2.1 upgrade.