Skip to content

AddAstrictionToCoimage - #225

Merged
zickgraf merged 3 commits into
homalg-project:masterfrom
mohamed-barakat:CoimageProjection
Nov 6, 2023
Merged

AddAstrictionToCoimage#225
zickgraf merged 3 commits into
homalg-project:masterfrom
mohamed-barakat:CoimageProjection

Conversation

@mohamed-barakat

@mohamed-barakat mohamed-barakat commented Oct 4, 2023

Copy link
Copy Markdown
Member

AddAstrictionToCoimage

ImageEmbedding( phi ) ⤳ Set
AstrictionToCoimage( phi ) ⤳ DuplicateFreeList

and compiled CoimageProjection

needs Toposes v2023.10-13

@mohamed-barakat
mohamed-barakat force-pushed the CoimageProjection branch 4 times, most recently from f243961 to 87a20f9 Compare October 4, 2023 12:50
@codecov

codecov Bot commented Oct 4, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
PackageInfo.g 100.00% <100.00%> (ø)
gap/SkeletalFinSets.gi 100.00% <100.00%> (ø)
...fFiniteSetsWithMorphismsGivenByListsPrecompiled.gi 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@mohamed-barakat mohamed-barakat changed the title AddCoimageObject & AddCoimageProjectionWithGivenCoimageObject AddCoimageProjection Oct 4, 2023
@mohamed-barakat
mohamed-barakat force-pushed the CoimageProjection branch 2 times, most recently from 97be517 to e9a1437 Compare October 17, 2023 16:45
@mohamed-barakat mohamed-barakat changed the title AddCoimageProjection AddAstrictionToCoimage Oct 17, 2023
@mohamed-barakat

mohamed-barakat commented Oct 17, 2023

Copy link
Copy Markdown
Member Author

This PR will fail until homalg-project/CAP_project#1495 is merged.

@mohamed-barakat

Copy link
Copy Markdown
Member Author

@zickgraf: I think the last commit is what you had in mind :)

@mohamed-barakat
mohamed-barakat force-pushed the CoimageProjection branch 2 times, most recently from 768a6da to d59ad00 Compare October 27, 2023 15:48
@zickgraf

Copy link
Copy Markdown
Member

@zickgraf: I think the last commit is what you had in mind :)

Yes, now we have the full analogy to the image and the code is much simpler :-)

Please add some tests for the newly added/compiled functions.

@mohamed-barakat

Copy link
Copy Markdown
Member Author

@zickgraf: I think the last commit is what you had in mind :)

Yes, now we have the full analogy to the image and the code is much simpler :-)

Nice :)

Please add some tests for the newly added/compiled functions.

I am preparing an example :)

ImageEmbedding( phi )      ⤳ Set
AstrictionToCoimage( phi ) ⤳ DuplicateFreeList

and compiled CoimageProjection

needs Toposes v2023.10-13
@zickgraf
zickgraf merged commit 079eb91 into homalg-project:master Nov 6, 2023
@mohamed-barakat
mohamed-barakat deleted the CoimageProjection branch November 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants