AddAstrictionToCoimage - #225
Merged
zickgraf merged 3 commits intoNov 6, 2023
Merged
Conversation
mohamed-barakat
force-pushed
the
CoimageProjection
branch
4 times, most recently
from
October 4, 2023 12:50
f243961 to
87a20f9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
mohamed-barakat
force-pushed
the
CoimageProjection
branch
from
October 4, 2023 13:27
87a20f9 to
65ef4a2
Compare
mohamed-barakat
force-pushed
the
CoimageProjection
branch
2 times, most recently
from
October 17, 2023 16:45
97be517 to
e9a1437
Compare
Member
Author
|
|
Member
Author
|
@zickgraf: I think the last commit is what you had in mind :) |
and compiled CoastrictionToImage
mohamed-barakat
force-pushed
the
CoimageProjection
branch
2 times, most recently
from
October 27, 2023 15:48
768a6da to
d59ad00
Compare
Member
Yes, now we have the full analogy to the image and the code is much simpler :-) Please add some tests for the newly added/compiled functions. |
Member
Author
Nice :)
I am preparing an example :) |
mohamed-barakat
force-pushed
the
CoimageProjection
branch
from
October 27, 2023 16:49
d59ad00 to
90bdeea
Compare
ImageEmbedding( phi ) ⤳ Set AstrictionToCoimage( phi ) ⤳ DuplicateFreeList and compiled CoimageProjection needs Toposes v2023.10-13
mohamed-barakat
force-pushed
the
CoimageProjection
branch
from
November 4, 2023 19:57
90bdeea to
240dcdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddAstrictionToCoimage
ImageEmbedding( phi ) ⤳ Set
AstrictionToCoimage( phi ) ⤳ DuplicateFreeList
and compiled CoimageProjection
needs Toposes v2023.10-13