Construct FiniteSkeletalDiscreteCategory from a single integer argument - #1871
Open
TKuh wants to merge 3 commits into
Open
Construct FiniteSkeletalDiscreteCategory from a single integer argument#1871TKuh wants to merge 3 commits into
FiniteSkeletalDiscreteCategory from a single integer argument#1871TKuh wants to merge 3 commits into
Conversation
and not a list of GAP objects.
so that the actual installed function for IsEqualForMorphisms is executed and not just its redirect function.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1871 +/- ##
=======================================
Coverage 80.76% 80.77%
=======================================
Files 589 589
Lines 86321 86326 +5
=======================================
+ Hits 69720 69726 +6
+ Misses 16601 16600 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mohamed-barakat
requested changes
Aug 5, 2026
mohamed-barakat
left a comment
mohamed-barakat
left a comment
Member
There was a problem hiding this comment.
I don't like this PR because
- it is downgrading an existing functionality
- the numbering is not compatible with
SkeletalFinSetsbut withSkeletalFinSets1.
As you see from the PR, the body of the implementation did not change, so you can use it to create three different constructors, or one constructor with internals depending on the input:
- the old behavior with an input list
nmeans[ 0 .. n-1 ]nmeans[ 1 .. n ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And not from a list of GAP objects. This streamlines it with
SkeletaFinSets.Additionally, set
overhead := falsein an example, to (hopefully) increase the code coverage.