Fix trust anchor matching for cross-signed certificates#175
Open
BernhardK91 wants to merge 1 commit into
Open
Conversation
When a TLS server sends a cross-signed root CA certificate in the chain (e.g. GTS Root R4 signed by GlobalSign), the previous exact byte comparison via .equals() fails to match it against the self-signed version in the truststore, even though both certificates represent the same CA with the same subject and public key. This causes "Trust anchor for certification path not found" errors for servers that include cross-signed root certificates in their TLS chain, which is common with Google Trust Services certificates. Match trust anchors by subject DN + public key instead of exact certificate equality, consistent with RFC 5280 trust anchor identification.
Collaborator
|
Hi @BernhardK91, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a TLS server includes a cross-signed root CA certificate in the chain (e.g. GTS Root R4 signed by GlobalSign), the current exact byte comparison via
.equals()fails to match it against the self-signed version in the truststore. Both certificates represent the same CA with the same subject and public key, but have different issuers and signatures.This causes "Trust anchor for certification path not found" errors for servers that include cross-signed root certificates in their TLS chain, which is common with Google Trust Services certificates.
The fix matches trust anchors by subject DN + public key instead of exact certificate equality, consistent with RFC 5280 trust anchor identification.