Decouple node-canvas dependency from the main package. #399
Open
virbas wants to merge 2 commits intohiukim:masterfrom
Open
Decouple node-canvas dependency from the main package. #399virbas wants to merge 2 commits intohiukim:masterfrom
virbas wants to merge 2 commits intohiukim:masterfrom
Conversation
… package for createImageTargetLibrary.js, create an example of creating .mind files using node & puppeteer (does not require node_canvas)
virbas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple
canvasfrom the main package.canvasis only used in the example how to generate .mind files using node.js, however it's included as a dependency in package.json.npm i mind-armight fail to install becausecanvasdependents on a bunch of optional system libs (see installation wiki https://github.com/Automattic/node-canvas/wiki).What has changed:
examples/nodejs/createImageTargetLibrary.jsnow contains it's own npm project, so it does not interfere with the main package build.