fix: isolate worker-local Wasm failures - #13
Merged
Conversation
Keep thread-local start, configure, and recovery failures on the affected local Wasm instead of poisoning the shared base. Guard Wasm and plugin cache eviction by generation identity so delayed callbacks cannot remove a replacement. Restore the recovered plugin callback key, make plugin destruction tolerate killed Wasm handles, and preserve the Higress bounded stale-cache bookkeeping when publishing recovered handles. (cherry picked from commit 3a5e47185fa58e33dcea93b1e92353b7a10dae2a) Signed-off-by: zty98751 <zty98751@alibaba-inc.com>
Keep worker clone and initialization failures scoped to the thread-local generation instead of marking the shared base Wasm as failed. Preserve precise clone failure states, use a clone-local fallback for unclassified initialization failures, and keep cache publication success-only. Extend the worker failure matrix to verify result propagation, base reuse, cache isolation, and recovery with the same VM key. (cherry picked from commit a6272982e9f7262ba37f2c5f208bddd94ed0a45a) Signed-off-by: zty98751 <zty98751@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
The result-returning worker creation API is additive; existing APIs are retained. The imported tests use the Higress fixture VM factory (
makeVm(engine_)).Validation
bazel test //test:wasm_test --define engine=v8 --test_output=errors --jobs=16 --local_cpu_resources=16 --loading_phase_threads=16— 13 tests passed.GitHub Actions checks are running.