fix: bump proxy_wasm_cpp_host pin for doAfterVmCallActions drain-to-local (#4034) - #28
Merged
Merged
Conversation
…in-to-local Picks up higress-group/proxy-wasm-cpp-host#12, which makes WasmBase::doAfterVmCallActions reentry-safe by draining the after_vm_call_actions_ queue into a stack-local before iterating. This fixes the worker-thread CPU 100% infinite loop reported in higress-group/higress#4034 (onRedisCallFailure + injectEncodedDataToFilterChain synchronous reentry). pwh merge commit: d1ab18f0988d3d65e9e18733e8616a702ba606f4 Signed-off-by: 澄潭 <zty98751@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps the
proxy_wasm_cpp_hostpin inbazel/repository_locations.bzlfrom8549cf63tod1ab18f0, picking up higress-group/proxy-wasm-cpp-host#12.8549cf6374835d225edf67e584cb8d8d8a0fc256d1ab18f0988d3d65e9e18733e8616a702ba606f4ee53c427…39ab7cd93eedd95d…b97410fd2024-05-182026-07-06The bump is exactly 1 commit ahead, 0 behind — the single picked-up commit is the drain-to-local fix + regression test.
Why
WasmBase::doAfterVmCallActionsiterated theafter_vm_call_actions_member deque in place. Under synchronous reentry (a callback re-adding an action during the drain — e.g.onRedisCallFailure→injectEncodedDataToFilterChain), the loop never terminated, spinning a worker thread at 100% CPU. See higress-group/higress#4034.The fix swaps the queue into a stack-local before iterating, so re-added actions land in the emptied member queue and are drained by the next-outer
DeferAfterCallActionsframe instead of re-run in the same loop.Scope
Layer A only (drain-to-local). No ABI/API change; no plugin-visible change.
master)