HHH-20341: Pass Maven mirror configuration to embedded MavenCli in integration tests#12177
HHH-20341: Pass Maven mirror configuration to embedded MavenCli in integration tests#12177yrodiere merged 7 commits intohibernate:mainfrom
Conversation
yrodiere
left a comment
There was a problem hiding this comment.
Thanks, LGTM but I'm not sure about logging
750f17f to
9cd63dd
Compare
|
@yrodiere The Jenkins CI runs now without any problems. It seems that the mavenMirror is not needed at all (that was the one Maven was trying to use on Jenkins but that was unreachable. Just using the normal .m2/repository on the host machine (that is also used by Gradle) is enough. |
yrodiere
left a comment
There was a problem hiding this comment.
It seems that the mavenMirror is not needed at all
It's not needed, but it's desired in order to reduce downloads.
that was the one Maven was trying to use on Jenkins but that was unreachable
When? I had to restart it on April 16th between 7PM and 8PM, does that match your problem?
Of course the proxy is only reachable from within our CI environment, it's not exposed to the internet in general and to your own machine in particular.
Just using the normal .m2/repository on the host machine (that is also used by Gradle) is enough.
That's correct, it seems we have a softlink from /home/jenkins/.m2 to the place we actually want to use: https://github.com/hibernate/hibernate-infra/blob/fabe181e8295c5035a8fba76119f38f7935fc436/roles/jenkins-worker/tasks/main.yml#L90-L93
That being said, given that's the default, I don't understand how this PR changes anything, or how that relates to the inability to download artifacts.
…ojoTestIT Signed-off-by: Koen Aers <koen.aers@gmail.com>
…sTestIT and TransformHbmTestIT Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
|



By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
Please make sure that the following tasks are completed:
Tasks specific to HHH-20341 (Task):
documentation/src/main/asciidoc/userguidefor all features,documentation/src/main/asciidoc/introductionfor main features, links from existing documentationmigration-guide.adoc(breaking changes) andwhats-new.adoc(new features/improvements)https://hibernate.atlassian.net/browse/HHH-20341