Skip to content

HHH-20341: Pass Maven mirror configuration to embedded MavenCli in integration tests#12177

Merged
yrodiere merged 7 commits intohibernate:mainfrom
koentsje:HHH-20341
Apr 29, 2026
Merged

HHH-20341: Pass Maven mirror configuration to embedded MavenCli in integration tests#12177
yrodiere merged 7 commits intohibernate:mainfrom
koentsje:HHH-20341

Conversation

@koentsje
Copy link
Copy Markdown
Member

@koentsje koentsje commented Apr 14, 2026


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.



Please make sure that the following tasks are completed:
Tasks specific to HHH-20341 (Task):

  • Add test OR check there is no need for a test
  • Update documentation as relevant: javadoc for changed API, documentation/src/main/asciidoc/userguide for all features, documentation/src/main/asciidoc/introduction for main features, links from existing documentation
  • Add entries as relevant to migration-guide.adoc (breaking changes) and whats-new.adoc (new features/improvements)

https://hibernate.atlassian.net/browse/HHH-20341

Copy link
Copy Markdown
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM but I'm not sure about logging

Comment thread tooling/hibernate-maven-plugin/hibernate-maven-plugin.gradle Outdated
@koentsje koentsje force-pushed the HHH-20341 branch 2 times, most recently from 750f17f to 9cd63dd Compare April 20, 2026 13:25
@koentsje koentsje marked this pull request as ready for review April 20, 2026 14:19
@koentsje
Copy link
Copy Markdown
Member Author

@yrodiere The Jenkins CI runs now without any problems. It seems that the mavenMirror is not needed at all (that was the one Maven was trying to use on Jenkins but that was unreachable. Just using the normal .m2/repository on the host machine (that is also used by Gradle) is enough.

Copy link
Copy Markdown
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the mavenMirror is not needed at all

It's not needed, but it's desired in order to reduce downloads.

that was the one Maven was trying to use on Jenkins but that was unreachable

When? I had to restart it on April 16th between 7PM and 8PM, does that match your problem?
Of course the proxy is only reachable from within our CI environment, it's not exposed to the internet in general and to your own machine in particular.

Just using the normal .m2/repository on the host machine (that is also used by Gradle) is enough.

That's correct, it seems we have a softlink from /home/jenkins/.m2 to the place we actually want to use: https://github.com/hibernate/hibernate-infra/blob/fabe181e8295c5035a8fba76119f38f7935fc436/roles/jenkins-worker/tasks/main.yml#L90-L93

That being said, given that's the default, I don't understand how this PR changes anything, or how that relates to the inability to download artifacts.

…ojoTestIT

Signed-off-by: Koen Aers <koen.aers@gmail.com>
…sTestIT and TransformHbmTestIT

Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
Signed-off-by: Koen Aers <koen.aers@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants