HHH-17767 - Add support for Value LOBs#12152
Open
loiclefevre wants to merge 1 commit intohibernate:7.4from
Open
HHH-17767 - Add support for Value LOBs#12152loiclefevre wants to merge 1 commit intohibernate:7.4from
loiclefevre wants to merge 1 commit intohibernate:7.4from
Conversation
|
beikov
reviewed
Apr 20, 2026
Comment on lines
+87
to
+88
| if( database.getDialect().supportsValueLOBAccess() ) { | ||
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo(columnName); |
Member
There was a problem hiding this comment.
Shouldn't you also ensure that the JavaType is a non-blob?
Suggested change
| if( database.getDialect().supportsValueLOBAccess() ) { | |
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo(columnName); | |
| if ( javaType.getJavaTypeClass() != Blob.class && database.getDialect().supportsValueLOBAccess() ) { | |
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo( columnName ); |
Comment on lines
+83
to
+84
| if( database.getDialect().supportsValueLOBAccess() ) { | ||
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo(columnName); |
Member
There was a problem hiding this comment.
Shouldn't you also ensure that the JavaType is a non-clob?
Suggested change
| if( database.getDialect().supportsValueLOBAccess() ) { | |
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo(columnName); | |
| if ( javaType.getJavaTypeClass() != Clob.class && database.getDialect().supportsValueLOBAccess() ) { | |
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo( columnName ); |
Comment on lines
+90
to
+91
| if( database.getDialect().supportsValueLOBAccess() ) { | ||
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo(columnName); |
Member
There was a problem hiding this comment.
Shouldn't you also ensure that the JavaType is a non-clob?
Suggested change
| if( database.getDialect().supportsValueLOBAccess() ) { | |
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo(columnName); | |
| if ( javaType.getJavaTypeClass() != Clob.class && javaType.getJavaTypeClass() != NClob.class && database.getDialect().supportsValueLOBAccess() ) { | |
| return database.getDialect().getValueLOBFragmentForExtraCreateTableInfo( columnName ); |
|
|
||
| @Override | ||
| public String getValueLOBFragmentForExtraCreateTableInfo(String columnName) { | ||
| return "\nlob(" + columnName + ") query as value"; |
Member
There was a problem hiding this comment.
Suggested change
| return "\nlob(" + columnName + ") query as value"; | |
| return " lob(" + columnName + ") query as value"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the support for VALUE LOBs for Oracle database 26ai. This is a performance improvement that lets LOB columns be defined as VALUE LOBs starting with 26ai.
Documentation: https://docs.oracle.com/en/database/oracle/oracle-database/26/adlob/value-based-LOBs.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
Please make sure that the following tasks are completed:
Tasks specific to HHH-17767 (Improvement):
documentation/src/main/asciidoc/userguidefor all features,documentation/src/main/asciidoc/introductionfor main features, links from existing documentationmigration-guide.adoc(breaking changes) andwhats-new.adoc(new features/improvements)https://hibernate.atlassian.net/browse/HHH-17767