fix(input): handle kitty shift-tab in settings - #2557
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughSettings key handling now dispatches normalized key codes across all sections. A regression test verifies Kitty keyboard protocol Shift+Tab navigation from Indicators to Theme. The changelog records the fix. ChangesSettings navigation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
LGTM. Checked and it works |
|
@akbash-bot the implementation review is clean. please rebase onto current master, resolve the changelog conflict, and rerun checks and both review bots. |
|
Rebased onto current I cannot update this PR’s head: it points to |
Summary
Tab + Shiftbefore Settings section dispatchChecks
cargo test app::input::settings::tests::kitty_shift_tab_moves_to_previous_settings_section -- --exact --nocapturecargo test app::input::settings::tests -- --nocapturejust ci 'all() - test(live_server_holds_one_pty_master_fd_per_pane)'(3333 tests passed; the excluded harness requirestarget/debug/herdrinside the checkout, while Kennel supplies an isolated externalCARGO_TARGET_DIR)just windows-lintrefs #2556