feat: add js, ts, jsx, tsx support by ShaunSHamilton · Pull Request #4 · helsing-ai/yadr

ShaunSHamilton · 2026-08-11T14:48:07Z

Main Notes

tree_sitter_typescript dependency added
LANGUAGE_TYPESCRIPT is used to parse JS and TS, because TS is superset of JS
- this just has the perk of fewer deps
- same for LANGUAGE_TSX
library allows a single yadr to be comprised over adjacent comments. ~~The parsing logic made sense until jsx entered the picture with {/* Comment */}~~ EDIT: Decided to remove support for multi-expression yadr for jsx.
I removed some hard-coded comments in the cli test file

jonhoo

Thanks! Let's make a simplifying assumption here ^

jonhoo

Did a more thorough review this time :)

jonhoo · 2026-08-11T21:05:24Z

+// and the TypeScript fixture, both of the comment forms their closely
+// -related grammars share are exercised.


Why the hard line-wrap here?

Based on the rest of the code, I thought there was a 100 char line length limit.

But the line above is not wrapped and is longer?

jonhoo · 2026-08-11T21:06:26Z

+// The statement is written as a JSDoc block, which is the shape TypeScript code bases reach for
+// and the one no other fixture in this tree covers.


Doesn't panel.tsx exercise this exact same thing?

👍 Right. I added TS before deciding to add the other languages

I guess what I mean is that we probably don't need both of those tests then — one would be sufficient.

jonhoo · 2026-08-11T21:07:52Z

+  return (
+    <aside role="status">
+      {/*
+       * YADR: 2024-09-05 Render the banner as a sibling of the page content


Instead of inventing new YADRs for each fixture, we should just make all the fixtures (going forward — no need to change the old ones) use placeholders for each parameter position. So, for example, <use case/user story u>, or maybe even just <u>.

jonhoo · 2026-08-11T21:08:37Z

+        // a block never spans two matches, so `last_line` is only ever compared against comments
+        // from the same one. A `(comment)+` pattern groups comments that are *siblings*, which
+        // for a run of `//` or `#` lines is the whole run.
+        //
+        // JSX is the exception, and the reason a Y-Statement written in markup has to sit in a
+        // single `{/* ... */}`. Each container wraps its comment in a `jsx_expression` of its own,
+        // making a run of them only-children rather than siblings, so tree-sitter reports one
+        // match each and they are never grouped. Therefore, spreading a statement over a run of
+        // containers is rejected rather than read.


This comment isn't particularly useful, and can be cut.

jonhoo · 2026-08-11T21:11:00Z

+/// `banner.jsx` writes its statement inside JSX markup, in a single `{/* ... */}` container, which
+/// is the only comment syntax available in a children position and the only shape a statement in
+/// markup may take. Nothing else in the tree covers a statement that is not at the top level of a
+/// file.
+///
+/// Asserting on the reflowed prose rather than on the title is what makes this worth having: a
+/// title survives almost any mishandling of the container, whereas the paragraphs only come out
+/// whole if the `*` on each line came off and the `{` and `}` around the comment stayed out.


The comments on all these test cases (here and on instas.rs) are too much. Most probably don't need a comment at all, or could get away with a single line (or maybe sentence).

jonhoo · 2026-08-11T21:12:27Z

+/// `ALL` is what `FromStr` searches and what the unknown-language error lists, so a variant left
+/// out of it is unusable from the command line however well it parses.
+#[test]
+fn all_lists_every_supported_language() {


This test isn't useful, since it'd just be yet another place where we'd need to remember to add a language.

jonhoo · 2026-08-11T21:12:51Z

+}
+
+#[test]
+fn typescript_is_selected_for_ts_files() {


This feels like a test that doesn't belong in this file (or anywhere).

jonhoo · 2026-08-11T21:13:54Z

+Spreading one statement over a run of shorter containers is unsupported:
+
+```jsx
+{
+  /* YADR: YYYY-MM-DD some title */
+}
+{
+  /* */
+}
+{
+  /* In the context of ... */
+}
+```
+
+Everywhere else, a run of adjacent comments is read as one block. Each `{/* ... */}` is a JSX expression of its own rather than a plain comment, and how such containers are laid out across lines is decided by whatever formats the file. Grouping them by line would let a reformat quietly change what a statement says, so a statement in markup is kept to one container instead.
+


This part can be cut.

jonhoo · 2026-08-11T21:14:15Z

+- Apache License, Version 2.0
+  ([LICENSE-APACHE](LICENSE-APACHE) or <http://www.apache.org/licenses/LICENSE-2.0>)
+- MIT license
+  ([LICENSE-MIT](LICENSE-MIT) or <http://opensource.org/licenses/MIT>)


This change is unrelated and shouldn't be in this PR.

jonhoo · 2026-08-11T21:14:22Z

+   content or decision's validity, simply make the necessary corrections without
+   updating the date or maintaining a changelog.


No need to change these in this PR.

jonhoo · 2026-08-11T21:16:05Z

Also, this reads a lot like you're using an LLM to assist you in the work. That's totally fine, but I'd then prefer a Co-Authored-By line on the commits (like most agents automatically include) so that we maintain the transparency on what is written by agents :)

ShaunSHamilton · 2026-08-12T07:28:50Z

I used an LLM for the tests and readme. So, let me know if you would prefer me to rebase with two commits (one with Co-authored-by: Claude).

jonhoo · 2026-08-14T13:33:58Z

I used an LLM for the tests and readme. So, let me know if you would prefer me to rebase with two commits (one with Co-authored-by: Claude).

No, I think it's fine to just include it with upcoming commits that have that property :)

jonhoo reviewed Aug 11, 2026

View reviewed changes

Comment thread tests/fixtures/clean/banner.jsx Outdated

jonhoo reviewed Aug 11, 2026

View reviewed changes

ShaunSHamilton added 11 commits August 20, 2026 08:49

feat: add typescript language support

89ac0bc

feat: add js, tsx, jsx support

bbb3dc6

fix: allow multi-expression jsx yadrs

e62d483

chore: update changelog

0bcda3e

change: force jsx yadrs to be single-expression-only

af9df2b

chore: undo auto-format changes in readme

4903c00

tests: standardize fixture yadr

c5e4542

chore: remove undesirable comments

fa12275

tests: remove language ALL checks

3c6cd14

tests: remove extra test file for jsdoc comments

9fb03ab

chore: reduce comment copy

9eda65b

ShaunSHamilton force-pushed the feat_js-ts-support branch from 410e060 to 9eda65b Compare August 20, 2026 07:00

		// and the TypeScript fixture, both of the comment forms their closely
		// -related grammars share are exercised.

		// The statement is written as a JSDoc block, which is the shape TypeScript code bases reach for
		// and the one no other fixture in this tree covers.

		content or decision's validity, simply make the necessary corrections without
		updating the date or maintaining a changelog.

Uh oh!

Conversation

ShaunSHamilton commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonhoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jonhoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonhoo commented Aug 11, 2026

Uh oh!

ShaunSHamilton commented Aug 12, 2026

Uh oh!

jonhoo commented Aug 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShaunSHamilton commented Aug 11, 2026 •

edited

Loading