Skip to content

#7937 fix: allow TestBed.inject overrides for mocked declarations#13312

Merged
satanTime merged 2 commits into
help-me-mom:mainfrom
satanTime:issues/7937
May 31, 2026
Merged

#7937 fix: allow TestBed.inject overrides for mocked declarations#13312
satanTime merged 2 commits into
help-me-mom:mainfrom
satanTime:issues/7937

Conversation

@satanTime
Copy link
Copy Markdown
Member

Closes #7937

Summary

  • track explicit TestBed.inject/get calls for mocked declarations
  • replay seeded descriptor overrides onto later declaration-local mock instances
  • add regression coverage for pipes, directives, and components plus internal helpers/overrides

Validation

  • COMPOSE_PROJECT_NAME=ngmocks_7937 sh ./test.sh root
  • COMPOSE_PROJECT_NAME=ngmocks_7937 sh ./test.sh coverage

@satanTime satanTime force-pushed the issues/7937 branch 2 times, most recently from c1f6b18 to e8debd2 Compare March 15, 2026 18:38
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c8bcac3) to head (f9d89b1).

Additional details and impacted files
@@            Coverage Diff            @@
##              main    #13312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          229       231    +2     
  Lines         4249      4317   +68     
  Branches      1212      1233   +21     
=========================================
+ Hits          4249      4317   +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@satanTime satanTime force-pushed the issues/7937 branch 3 times, most recently from b49dc91 to 65614e0 Compare March 15, 2026 19:45
@satanTime satanTime force-pushed the issues/7937 branch 2 times, most recently from 62353a9 to 5cb68f7 Compare May 26, 2026 08:47
@satanTime satanTime enabled auto-merge (squash) May 31, 2026 11:09
@satanTime satanTime disabled auto-merge May 31, 2026 11:09
@satanTime satanTime merged commit d0743f6 into help-me-mom:main May 31, 2026
5 checks passed
@satanTime satanTime deleted the issues/7937 branch May 31, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: cannot set return value of DI'ed pipe

1 participant