docs: Document toPrettyJson HTML character preservation#2050
Draft
promptless-for-oss wants to merge 1 commit intohelm:mainfrom
Draft
docs: Document toPrettyJson HTML character preservation#2050promptless-for-oss wants to merge 1 commit intohelm:mainfrom
promptless-for-oss wants to merge 1 commit intohelm:mainfrom
Conversation
Signed-off-by: promptless-for-oss <promptless-for-oss@users.noreply.github.com>
|
|
||
| The `toPrettyJson` function encodes an item into a pretty (indented) JSON | ||
| string. | ||
| string with HTML characters (`&`, `<`, `>`) preserved. This means URLs and |
Contributor
Author
There was a problem hiding this comment.
Citation: Based on PR #31964 which overrides toPrettyJson and mustToPrettyJson in the engine FuncMap to use json.Encoder with SetEscapeHTML(false), preserving &, <, > characters literally instead of HTML-escaping them to Unicode sequences.
View source
|
|
||
| The `toPrettyJson` function encodes an item into a pretty (indented) JSON | ||
| string. | ||
| string with HTML characters (`&`, `<`, `>`) preserved. This means URLs and |
Contributor
Author
There was a problem hiding this comment.
Citation: Based on PR #31964 which overrides toPrettyJson and mustToPrettyJson in the engine FuncMap to use json.Encoder with SetEscapeHTML(false), preserving &, <, > characters literally instead of HTML-escaping them to Unicode sequences.
View source
5 tasks
TerryHowe
added
awaiting release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open this suggestion in Promptless to view citations and reasoning process
Updates the
toPrettyJsonandmustToPrettyJsondocumentation to clarify that these functions preserve HTML characters (&,<,>) without escaping them to Unicode sequences like\u0026. This documents the bug fix from helm/helm#31964, which makes URLs and other strings containing these characters render correctly in JSON output.Trigger Events
helm/helm PR #31964: fix(engine): override toPrettyJson to disable HTML escaping
Promptless Research (5 files, 1 GitHub PR)
.long_term_context/product_knowledge/product_overview.md.long_term_context/doc_workflow/client_instructions.md.long_term_context/style/client_style_guide.mddocs/chart_template_guide/function_list.mdxversioned_docs/version-3/chart_template_guide/function_list.mdAgent Response
Tip: Tag @Promptless in GitHub PR comments to guide documentation changes during code review 🐙