Open
Conversation
Signed-off-by: Fabian Ruff <fabian.ruff@sap.com>
This was referenced Dec 8, 2023
|
Any news? |
hickeyma
suggested changes
Jul 10, 2024
Contributor
hickeyma
left a comment
There was a problem hiding this comment.
Thanks @databus23 for pushing the fix. Suggestion in line.
Do you mind add adding to the description that this closes #113?
Comment on lines
34
to
37
| "k8s.io/client-go/kubernetes" | ||
| _ "k8s.io/client-go/plugin/pkg/client/auth/oidc" | ||
| "k8s.io/client-go/rest" | ||
| "k8s.io/client-go/tools/clientcmd" |
Contributor
There was a problem hiding this comment.
Suggested change
| "k8s.io/client-go/kubernetes" | |
| _ "k8s.io/client-go/plugin/pkg/client/auth/oidc" | |
| "k8s.io/client-go/rest" | |
| "k8s.io/client-go/tools/clientcmd" | |
| "k8s.io/client-go/kubernetes" | |
| "k8s.io/client-go/rest" | |
| "k8s.io/client-go/tools/clientcmd" | |
| // Enable usage of the following providers | |
| _ "k8s.io/client-go/plugin/pkg/client/auth/azure" | |
| _ "k8s.io/client-go/plugin/pkg/client/auth/gcp" | |
| _ "k8s.io/client-go/plugin/pkg/client/auth/oidc" |
|
This clearly needs to be applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This awesome plugin does not work for our kubeconfigs which rely on oidc as the auth provider:
Fixes #113